From: Ming Lei <ming.lei@redhat.com>
To: Nilay Shroff <nilay@linux.ibm.com>
Cc: linux-block@vger.kernel.org, hch@lst.de, axboe@kernel.dk,
yi.zhang@redhat.com, czhong@redhat.com, yukuai@fnnas.com,
gjoyce@ibm.com
Subject: Re: [PATCHv5 2/5] block: move elevator tags into struct elevator_resources
Date: Wed, 12 Nov 2025 18:37:28 +0800 [thread overview]
Message-ID: <aRRjaCbc-Vcd1iqY@fedora> (raw)
In-Reply-To: <20251112052848.1433256-3-nilay@linux.ibm.com>
On Wed, Nov 12, 2025 at 10:56:03AM +0530, Nilay Shroff wrote:
> This patch introduces a new structure, struct elevator_resources, to
> group together all elevator-related resources that share the same
> lifetime. As a first step, this change moves the elevator tag pointer
> from struct elv_change_ctx into the new struct elevator_resources.
>
> Additionally, rename blk_mq_alloc_sched_tags_batch() and
> blk_mq_free_sched_tags_batch() to blk_mq_alloc_sched_res_batch() and
> blk_mq_free_sched_res_batch(), respectively. Introduce two new wrapper
> helpers, blk_mq_alloc_sched_res() and blk_mq_free_sched_res(), around
> blk_mq_alloc_sched_tags() and blk_mq_free_sched_tags().
>
> These changes pave the way for consolidating the allocation and freeing
> of elevator-specific resources into common helper functions. This
> refactoring improves encapsulation and prepares the code for future
> extensions, allowing additional elevator-specific data to be added to
> struct elevator_resources without cluttering struct elv_change_ctx.
>
> Subsequent patches will extend struct elevator_resources to include
> other elevator-related data.
>
> Signed-off-by: Nilay Shroff <nilay@linux.ibm.com>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Thanks,
Ming
next prev parent reply other threads:[~2025-11-12 10:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-12 5:26 [PATCHv5 0/5] block: restructure elevator switch path and fix a lockdep splat Nilay Shroff
2025-11-12 5:26 ` [PATCHv5 1/5] block: unify elevator tags and type xarrays into struct elv_change_ctx Nilay Shroff
2025-11-12 5:26 ` [PATCHv5 2/5] block: move elevator tags into struct elevator_resources Nilay Shroff
2025-11-12 10:37 ` Ming Lei [this message]
2025-11-12 5:26 ` [PATCHv5 3/5] block: introduce alloc_sched_data and free_sched_data elevator methods Nilay Shroff
2025-11-12 10:34 ` Ming Lei
2025-11-12 13:05 ` Nilay Shroff
2025-11-12 5:26 ` [PATCHv5 4/5] block: use {alloc|free}_sched data methods Nilay Shroff
2025-11-12 10:38 ` Ming Lei
2025-11-12 5:26 ` [PATCHv5 5/5] block: define alloc_sched_data and free_sched_data methods for kyber Nilay Shroff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRRjaCbc-Vcd1iqY@fedora \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=czhong@redhat.com \
--cc=gjoyce@ibm.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=nilay@linux.ibm.com \
--cc=yi.zhang@redhat.com \
--cc=yukuai@fnnas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).