From: Christoph Hellwig <hch@infradead.org>
To: chengkaitao <pilgrimtao@gmail.com>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org,
Chengkaitao <chengkaitao@kylinos.cn>
Subject: Re: [PATCH v2] block/mq-deadline: Remove redundant hctx pointer dereferencing operation
Date: Mon, 17 Nov 2025 22:08:20 -0800 [thread overview]
Message-ID: <aRwNVAk1dnoJwYSZ@infradead.org> (raw)
In-Reply-To: <20251118012539.61711-1-pilgrimtao@gmail.com>
On Tue, Nov 18, 2025 at 09:25:39AM +0800, chengkaitao wrote:
> From: Chengkaitao <chengkaitao@kylinos.cn>
>
> The value of 'hctx->queue' is already stored in '*q' within
> dd_insert_requests, we can directly reuse the result instead of
> dereferencing hctx again in the dd_insert_request function. This
> patch removes the redundant operation and modifies the function's
> parameters accordingly. We can eliminate an LDR instruction.
But you pass additional parameters on the stack. Aka you're causing
churn here with bogus arguments.
next prev parent reply other threads:[~2025-11-18 6:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-18 1:25 [PATCH v2] block/mq-deadline: Remove redundant hctx pointer dereferencing operation chengkaitao
2025-11-18 6:08 ` Christoph Hellwig [this message]
2025-11-18 7:24 ` Tao pilgrim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRwNVAk1dnoJwYSZ@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=chengkaitao@kylinos.cn \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pilgrimtao@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox