From: Keith Busch <kbusch@kernel.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: nvme discard issue
Date: Tue, 18 Nov 2025 08:34:00 -0700 [thread overview]
Message-ID: <aRyR6MaF5-CoVRDW@kbusch-mbp> (raw)
In-Reply-To: <0767437b-3861-479e-aee2-d4f5cce9f6eb@kernel.dk>
On Tue, Nov 18, 2025 at 08:28:16AM -0700, Jens Axboe wrote:
> On 11/18/25 8:22 AM, Keith Busch wrote:
> > On Tue, Nov 18, 2025 at 07:24:59AM -0700, Jens Axboe wrote:
> >> commit 2516c246d01c23a5f5310e9ac78d9f8aad9b1d0e
> >> Author: Keith Busch <kbusch@kernel.org>
> >> Date: Fri Nov 14 10:31:45 2025 -0800
> >>
> >> block: consider discard merge last
> >>
> >> This was just doing an allmodconfig build, using XFS as per the trace
> >> above. The fs is mounted:
> >
> > Huh, xfs was the only filesystem I tested, but obviously not enough. So
> > the segment accounting is off now, I'll take a look.
>
> It's all very strange - reverted the above commit, and ran into other
> issues. So may be something else entirely and your commit is fine. My
> for-6.19/block branch seems fine (?!?), but merged into master it's not.
Interesting, I'll keep testing futher back too.
But I do see a non-trivial problem with my patch, so I think you should
either drop or revert it at this time. For the discard back merge case,
ideally we'd just adjust the bio's bi_size and drop the second bio
completely.
Anyway, sorry, that was my mistake. I was trying to get nvme to hit a
previous bug from merging data-less bio's that nvme had dodged.
next prev parent reply other threads:[~2025-11-18 15:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-18 14:24 nvme discard issue Jens Axboe
2025-11-18 15:22 ` Keith Busch
2025-11-18 15:28 ` Jens Axboe
2025-11-18 15:34 ` Keith Busch [this message]
2025-11-18 15:38 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRyR6MaF5-CoVRDW@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox