linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: zhangshida <starzhangzsd@gmail.com>
Cc: Johannes.Thumshirn@wdc.com, hch@infradead.org,
	agruenba@redhat.com, ming.lei@redhat.com,
	hsiangkao@linux.alibaba.com, csander@purestorage.com,
	linux-block@vger.kernel.org, linux-bcache@vger.kernel.org,
	nvdimm@lists.linux.dev, virtualization@lists.linux.dev,
	ntfs3@lists.linux.dev, linux-xfs@vger.kernel.org,
	linux-kernel@vger.kernel.org, zhangshida@kylinos.cn
Subject: Re: [PATCH v3 2/9] block: prohibit calls to bio_chain_endio
Date: Sun, 30 Nov 2025 22:14:20 -0800	[thread overview]
Message-ID: <aS0yPEDwoc7cGAoe@infradead.org> (raw)
In-Reply-To: <20251129090122.2457896-3-zhangshida@kylinos.cn>

On Sat, Nov 29, 2025 at 05:01:15PM +0800, zhangshida wrote:
> From: Shida Zhang <zhangshida@kylinos.cn>
> 
> Now that all potential callers of bio_chain_endio have been
> eliminated, completely prohibit any future calls to this function.

Note that we'll need to be prepared for a flame from Linus for
using BUG_ON, but I still think it is reasonable here.

Reviewed-by: Christoph Hellwig <hch@lst.de>


  reply	other threads:[~2025-12-01  6:14 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-29  9:01 [PATCH v3 0/9] Fix bio chain related issues zhangshida
2025-11-29  9:01 ` [PATCH v3 1/9] md: bcache: fix improper use of bi_end_io zhangshida
2025-12-01  5:45   ` Coly Li
2025-12-01  8:29     ` Stephen Zhang
2025-11-29  9:01 ` [PATCH v3 2/9] block: prohibit calls to bio_chain_endio zhangshida
2025-12-01  6:14   ` Christoph Hellwig [this message]
2025-11-29  9:01 ` [PATCH v3 3/9] block: prevent race condition on bi_status in __bio_chain_endio zhangshida
2025-12-01  6:14   ` Christoph Hellwig
2025-12-06 18:01   ` kernel test robot
2025-11-29  9:01 ` [PATCH v3 4/9] block: export bio_chain_and_submit zhangshida
2025-12-01  6:15   ` Christoph Hellwig
2025-11-29  9:01 ` [PATCH v3 5/9] xfs: Replace the repetitive bio chaining code patterns zhangshida
2025-11-29  9:01 ` [PATCH v3 6/9] block: " zhangshida
2025-11-29  9:01 ` [PATCH v3 7/9] fs/ntfs3: " zhangshida
2025-11-29  9:01 ` [PATCH v3 8/9] zram: " zhangshida
2025-12-04  9:00   ` Sergey Senozhatsky
2025-11-29  9:01 ` [PATCH v3 9/9] nvdimm: " zhangshida

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aS0yPEDwoc7cGAoe@infradead.org \
    --to=hch@infradead.org \
    --cc=Johannes.Thumshirn@wdc.com \
    --cc=agruenba@redhat.com \
    --cc=csander@purestorage.com \
    --cc=hsiangkao@linux.alibaba.com \
    --cc=linux-bcache@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=ntfs3@lists.linux.dev \
    --cc=nvdimm@lists.linux.dev \
    --cc=starzhangzsd@gmail.com \
    --cc=virtualization@lists.linux.dev \
    --cc=zhangshida@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).