Linux block layer
 help / color / mirror / Atom feed
From: Niklas Cassel <cassel@kernel.org>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org
Subject: Re: [PATCH] block: Clear BLK_ZONE_WPLUG_PLUGGED when aborting plugged BIOs
Date: Thu, 4 Dec 2025 14:45:17 +0100	[thread overview]
Message-ID: <aTGQbae97JLxouuS@ryzen> (raw)
In-Reply-To: <20251204105952.178201-1-dlemoal@kernel.org>

On Thu, Dec 04, 2025 at 07:59:52PM +0900, Damien Le Moal wrote:
> Commit fe0418eb9bd6 ("block: Prevent potential deadlocks in zone write
> plug error recovery") added a WARN check in disk_put_zone_wplug() to
> verify that when the last reference to a zone write plug is dropped,
> this zone write plug does not have the BLK_ZONE_WPLUG_PLUGGED flag set,
> that is, that it is not plugged.
> 
> However, the function disk_zone_wplug_abort(), which is called for zone
> reset and zone finish operations, does not clear this flag after
> emptying a zone write plug BIO list. This can result in the
> disk_put_zone_wplug() warning to trigger if the user (erroneously as
> that is bad pratcice) issues zone reset or zone finish operations while

s/pratcice/practice/

Regardless:
Reviewed-by: Niklas Cassel <cassel@kernel.org>

  parent reply	other threads:[~2025-12-04 13:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-04 10:59 [PATCH] block: Clear BLK_ZONE_WPLUG_PLUGGED when aborting plugged BIOs Damien Le Moal
2025-12-04 12:28 ` Johannes Thumshirn
2025-12-04 13:45 ` Niklas Cassel [this message]
2025-12-04 14:25 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aTGQbae97JLxouuS@ryzen \
    --to=cassel@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=dlemoal@kernel.org \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox