linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Caleb Sander Mateos <csander@purestorage.com>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org,
	Uday Shankar <ushankar@purestorage.com>
Subject: Re: [PATCH V5 11/21] ublk: document feature UBLK_F_BATCH_IO
Date: Sun, 7 Dec 2025 23:03:01 +0800	[thread overview]
Message-ID: <aTWXJRh9wqW4KG4g@fedora> (raw)
In-Reply-To: <CADUfDZpLrrjmxsmW-JyqLMLR_vFj0gropue9rTSns6ty+OxvCg@mail.gmail.com>

On Sun, Dec 07, 2025 at 12:22:38AM -0800, Caleb Sander Mateos wrote:
> On Tue, Dec 2, 2025 at 4:21 AM Ming Lei <ming.lei@redhat.com> wrote:
> >
> > Document feature UBLK_F_BATCH_IO.
> >
> > Signed-off-by: Ming Lei <ming.lei@redhat.com>
> > ---
> >  Documentation/block/ublk.rst | 64 +++++++++++++++++++++++++++++++++---
> >  1 file changed, 60 insertions(+), 4 deletions(-)
> >
> > diff --git a/Documentation/block/ublk.rst b/Documentation/block/ublk.rst
> > index 8c4030bcabb6..6ad28039663d 100644
> > --- a/Documentation/block/ublk.rst
> > +++ b/Documentation/block/ublk.rst
> > @@ -260,9 +260,12 @@ The following IO commands are communicated via io_uring passthrough command,
> >  and each command is only for forwarding the IO and committing the result
> >  with specified IO tag in the command data:
> >
> > -- ``UBLK_IO_FETCH_REQ``
> > +Traditional Per-I/O Commands
> > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >
> > -  Sent from the server IO pthread for fetching future incoming IO requests
> > +- ``UBLK_U_IO_FETCH_REQ``
> > +
> > +  Sent from the server I/O pthread for fetching future incoming I/O requests
> >    destined to ``/dev/ublkb*``. This command is sent only once from the server
> >    IO pthread for ublk driver to setup IO forward environment.
> >
> > @@ -278,7 +281,7 @@ with specified IO tag in the command data:
> >    supported by the driver, daemons must be per-queue instead - i.e. all I/Os
> >    associated to a single qid must be handled by the same task.
> >
> > -- ``UBLK_IO_COMMIT_AND_FETCH_REQ``
> > +- ``UBLK_U_IO_COMMIT_AND_FETCH_REQ``
> >
> >    When an IO request is destined to ``/dev/ublkb*``, the driver stores
> >    the IO's ``ublksrv_io_desc`` to the specified mapped area; then the
> > @@ -293,7 +296,7 @@ with specified IO tag in the command data:
> >    requests with the same IO tag. That is, ``UBLK_IO_COMMIT_AND_FETCH_REQ``
> >    is reused for both fetching request and committing back IO result.
> >
> > -- ``UBLK_IO_NEED_GET_DATA``
> > +- ``UBLK_U_IO_NEED_GET_DATA``
> >
> >    With ``UBLK_F_NEED_GET_DATA`` enabled, the WRITE request will be firstly
> >    issued to ublk server without data copy. Then, IO backend of ublk server
> > @@ -322,6 +325,59 @@ with specified IO tag in the command data:
> >    ``UBLK_IO_COMMIT_AND_FETCH_REQ`` to the server, ublkdrv needs to copy
> >    the server buffer (pages) read to the IO request pages.
> >
> > +Batch I/O Commands (UBLK_F_BATCH_IO)
> > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > +
> > +The ``UBLK_F_BATCH_IO`` feature provides an alternative high-performance
> > +I/O handling model that replaces the traditional per-I/O commands with
> > +per-queue batch commands. This significantly reduces communication overhead
> > +and enables better load balancing across multiple server tasks.
> > +
> > +Key differences from traditional mode:
> > +
> > +- **Per-queue vs Per-I/O**: Commands operate on queues rather than individual I/Os
> > +- **Batch processing**: Multiple I/Os are handled in single operations
> > +- **Multishot commands**: Use io_uring multishot for reduced submission overhead
> > +- **Flexible task assignment**: Any task can handle any I/O (no per-I/O daemons)
> > +- **Better load balancing**: Tasks can adjust their workload dynamically
> > +
> > +Batch I/O Commands:
> > +
> > +- ``UBLK_U_IO_PREP_IO_CMDS``
> > +
> > +  Prepares multiple I/O commands in batch. The server provides a buffer
> > +  containing multiple I/O descriptors that will be processed together.
> > +  This reduces the number of individual command submissions required.
> > +
> > +- ``UBLK_U_IO_COMMIT_IO_CMDS``
> > +
> > +  Commits results for multiple I/O operations in batch, and prepares the
> > +  I/O descriptors to accept new requests. The server provides a buffer
> > +  containing the results of multiple completed I/Os, allowing efficient
> > +  bulk completion of requests.
> > +
> > +- ``UBLK_U_IO_FETCH_IO_CMDS``
> > +
> > +  **Multishot command** for fetching I/O commands in batch. This is the key
> > +  command that enables high-performance batch processing:
> > +
> > +  * Uses io_uring multishot capability for reduced submission overhead
> > +  * Single command can fetch multiple I/O requests over time
> > +  * Buffer size determines maximum batch size per operation
> 
> The UBLK_U_IO_FETCH_IO_CMDS command specifies a buffer group, so is
> the expectation that there would be a single buffer in the group and

It is same with other mulishot request with provided buffer, and the group
can include 1 or more buffers.

> each command would use a different buffer group?

Yes, each command should use different buffer group like
io_uring_prep_read_multishot(), because tag may be read into the buffer when
the userspace is parsing/handling previous completed FETCH completion.


Thanks,
Ming


  reply	other threads:[~2025-12-07 15:03 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-02 12:18 [PATCH V5 00/21] ublk: add UBLK_F_BATCH_IO Ming Lei
2025-12-02 12:18 ` [PATCH V5 01/21] ublk: define ublk_ch_batch_io_fops for the coming feature F_BATCH_IO Ming Lei
2025-12-02 12:18 ` [PATCH V5 02/21] ublk: prepare for not tracking task context for command batch Ming Lei
2025-12-02 12:18 ` [PATCH V5 03/21] ublk: add new batch command UBLK_U_IO_PREP_IO_CMDS & UBLK_U_IO_COMMIT_IO_CMDS Ming Lei
2025-12-02 12:18 ` [PATCH V5 04/21] ublk: handle UBLK_U_IO_PREP_IO_CMDS Ming Lei
2025-12-02 12:18 ` [PATCH V5 05/21] ublk: handle UBLK_U_IO_COMMIT_IO_CMDS Ming Lei
2025-12-04  3:11   ` Caleb Sander Mateos
2025-12-02 12:19 ` [PATCH V5 06/21] ublk: add io events fifo structure Ming Lei
2025-12-04  3:16   ` Caleb Sander Mateos
2025-12-02 12:19 ` [PATCH V5 07/21] ublk: add batch I/O dispatch infrastructure Ming Lei
2025-12-04  3:38   ` Caleb Sander Mateos
2025-12-02 12:19 ` [PATCH V5 08/21] ublk: add UBLK_U_IO_FETCH_IO_CMDS for batch I/O processing Ming Lei
2025-12-07  7:38   ` Caleb Sander Mateos
2025-12-07 13:54     ` Ming Lei
2025-12-08 17:03       ` Caleb Sander Mateos
2025-12-07 13:56     ` Ming Lei
2025-12-08 17:04       ` Caleb Sander Mateos
2025-12-02 12:19 ` [PATCH V5 09/21] ublk: abort requests filled in event kfifo Ming Lei
2025-12-07  7:44   ` Caleb Sander Mateos
2025-12-02 12:19 ` [PATCH V5 10/21] ublk: add new feature UBLK_F_BATCH_IO Ming Lei
2025-12-07  8:16   ` Caleb Sander Mateos
2025-12-07 13:58     ` Ming Lei
2025-12-02 12:19 ` [PATCH V5 11/21] ublk: document " Ming Lei
2025-12-07  8:22   ` Caleb Sander Mateos
2025-12-07 15:03     ` Ming Lei [this message]
2025-12-08 21:10       ` Caleb Sander Mateos
2025-12-02 12:19 ` [PATCH V5 12/21] ublk: implement batch request completion via blk_mq_end_request_batch() Ming Lei
2025-12-02 12:19 ` [PATCH V5 13/21] selftests: ublk: fix user_data truncation for tgt_data >= 256 Ming Lei
2025-12-02 12:19 ` [PATCH V5 14/21] selftests: ublk: replace assert() with ublk_assert() Ming Lei
2025-12-02 12:19 ` [PATCH V5 15/21] selftests: ublk: add ublk_io_buf_idx() for returning io buffer index Ming Lei
2025-12-02 12:19 ` [PATCH V5 16/21] selftests: ublk: add batch buffer management infrastructure Ming Lei
2025-12-02 12:19 ` [PATCH V5 17/21] selftests: ublk: handle UBLK_U_IO_PREP_IO_CMDS Ming Lei
2025-12-02 12:19 ` [PATCH V5 18/21] selftests: ublk: handle UBLK_U_IO_COMMIT_IO_CMDS Ming Lei
2025-12-02 12:19 ` [PATCH V5 19/21] selftests: ublk: handle UBLK_U_IO_FETCH_IO_CMDS Ming Lei
2025-12-02 12:19 ` [PATCH V5 20/21] selftests: ublk: add --batch/-b for enabling F_BATCH_IO Ming Lei
2025-12-02 12:19 ` [PATCH V5 21/21] selftests: ublk: support arbitrary threads/queues combination Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aTWXJRh9wqW4KG4g@fedora \
    --to=ming.lei@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=csander@purestorage.com \
    --cc=linux-block@vger.kernel.org \
    --cc=ushankar@purestorage.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).