From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBE3A41C71 for ; Fri, 12 Dec 2025 03:06:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765508804; cv=none; b=ZbFkhmfJcO7sORBVFgPssrsJ6DAR1WMhuCAWGhZYGMuicRFBQ7B1PdY4JoSio2FHXg3ijNuDpMf0kwNdlICmcaaitbw1DsAxap35m4CacjFDIMgwjmsfJ7LMZs8KcRNzHO0zrsHgV2HAUUShJAikvVvqGAcTVcXw75tU3esbHvc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765508804; c=relaxed/simple; bh=9eb39L65kAGJnCwM/1QruYSkApWmJoDivxop4vb4SZ0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BJhIgswy0rGp6s4cEuHCwz/DTkc25+HeR3kpC0zRicNRRxs01iUsrKTa1ZYprkr1d3g3tqHVGkyJ52IN4aIWxWoPmzrOJf2/g0qV3Kb60V7FzPlLRh2n9U6Iu3ywASgJGWe7/gffq/jH1PfBH/3XKGyvlAay+Qqo+hVxMCOB7Rg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=IxibaOp9; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IxibaOp9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1765508801; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=79RBu1sB/suJPIq1HPzo4GbL8LvjGchoKhX3vbLfFRw=; b=IxibaOp9gCrwTiGEhJuRbFj43L1DW1GIdw0531+q+VtnxYdZJpdRJJb+EAof3DzQsZ552g wsFRsOa+cu5nNWuKEyQ6IORW9tQz9qnrK9AKgIO+vLvcU9xYM0DSpmdgSikVsmAnsXpJnU rF9uyHDnVPQJMHB3mZo/QfovB4kTcpA= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-77-hrYBU8dTOgq6-vxNDfy35w-1; Thu, 11 Dec 2025 22:06:36 -0500 X-MC-Unique: hrYBU8dTOgq6-vxNDfy35w-1 X-Mimecast-MFC-AGG-ID: hrYBU8dTOgq6-vxNDfy35w_1765508795 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 536A11801312; Fri, 12 Dec 2025 03:06:33 +0000 (UTC) Received: from fedora (unknown [10.72.116.129]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5AAEC194C386; Fri, 12 Dec 2025 03:06:27 +0000 (UTC) Date: Fri, 12 Dec 2025 11:06:19 +0800 From: Ming Lei To: Caleb Sander Mateos Cc: Shuah Khan , linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/8] selftests: ublk: use auto_zc for PER_IO_DAEMON tests in stress_04 Message-ID: References: <20251211051603.1154841-1-csander@purestorage.com> <20251211051603.1154841-5-csander@purestorage.com> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 On Thu, Dec 11, 2025 at 06:57:51PM -0800, Caleb Sander Mateos wrote: > On Thu, Dec 11, 2025 at 1:06 AM Ming Lei wrote: > > > > On Wed, Dec 10, 2025 at 10:15:59PM -0700, Caleb Sander Mateos wrote: > > > stress_04 is described as "run IO and kill ublk server(zero copy)" but > > > the --per_io_tasks tests cases don't use zero copy. Plus, one of the > > > test cases is duplicated. Add --auto_zc to these test cases and > > > --auto_zc_fallback to one of the duplicated ones. This matches the test > > > cases in stress_03. > > > > > > Signed-off-by: Caleb Sander Mateos > > > --- > > > tools/testing/selftests/ublk/test_stress_04.sh | 8 ++++---- > > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > > > diff --git a/tools/testing/selftests/ublk/test_stress_04.sh b/tools/testing/selftests/ublk/test_stress_04.sh > > > index 3f901db4d09d..965befcee830 100755 > > > --- a/tools/testing/selftests/ublk/test_stress_04.sh > > > +++ b/tools/testing/selftests/ublk/test_stress_04.sh > > > @@ -38,14 +38,14 @@ if _have_feature "AUTO_BUF_REG"; then > > > ublk_io_and_kill_daemon 256M -t stripe -q 4 --auto_zc --no_ublk_fixed_fd "${UBLK_BACKFILES[1]}" "${UBLK_BACKFILES[2]}" & > > > ublk_io_and_kill_daemon 8G -t null -q 4 -z --auto_zc --auto_zc_fallback & > > > fi > > > > > > if _have_feature "PER_IO_DAEMON"; then > > > - ublk_io_and_kill_daemon 8G -t null -q 4 --nthreads 8 --per_io_tasks & > > > - ublk_io_and_kill_daemon 256M -t loop -q 4 --nthreads 8 --per_io_tasks "${UBLK_BACKFILES[0]}" & > > > - ublk_io_and_kill_daemon 256M -t stripe -q 4 --nthreads 8 --per_io_tasks "${UBLK_BACKFILES[1]}" "${UBLK_BACKFILES[2]}" & > > > - ublk_io_and_kill_daemon 8G -t null -q 4 --nthreads 8 --per_io_tasks & > > > + ublk_io_and_kill_daemon 8G -t null -q 4 --auto_zc --nthreads 8 --per_io_tasks & > > > + ublk_io_and_kill_daemon 256M -t loop -q 4 --auto_zc --nthreads 8 --per_io_tasks "${UBLK_BACKFILES[0]}" & > > > + ublk_io_and_kill_daemon 256M -t stripe -q 4 --auto_zc --nthreads 8 --per_io_tasks "${UBLK_BACKFILES[1]}" "${UBLK_BACKFILES[2]}" & > > > + ublk_io_and_kill_daemon 8G -t null -q 4 --auto_zc --auto_zc_fallback --nthreads 8 --per_io_tasks & > > > > I'd rather to fix the test description, the original motivation is to cover > > more data copy parameters(--z, --auto_zc, plain copy) in same stress test. > > test_stress_02.sh ("run IO and kill ublk server") already covers plain > copy. But sure, I can change the test_stress_04.sh description to "... > (more features)" or something. oops, stress_02 is same kind of test with stress_04.sh, I missed this point. Your patch looks correct to make stress_04 for covering zero copy only. Sorry for the noise. Thanks, Ming