From: Keith Busch <kbusch@kernel.org>
To: Vitaliy Filippov <vitalifster@gmail.com>
Cc: linux-block@vger.kernel.org, linux-nvme@lists.infradead.org
Subject: Re: [PATCH v2] Do not require atomic writes to be power of 2 sized and aligned on length boundary
Date: Mon, 22 Dec 2025 07:17:15 +0800 [thread overview]
Message-ID: <aUh_--eKRKYOHzLz@kbusch-mbp> (raw)
In-Reply-To: <20251221132402.27293-1-vitalifster@gmail.com>
On Sun, Dec 21, 2025 at 04:24:02PM +0300, Vitaliy Filippov wrote:
> It contradicts NVMe specification where alignment is only required when atomic
> write boundary (NABSPF/NABO) is set and highly limits usage of NVMe atomic writes
Commit header is missing the "fs:" prefix, and the commit log should
wrap at 72 characters.
On the techincal side, this is a generic function used by multiple
protocols, so you can't just appeal to NVMe to justify removing the
checks.
NVMe still has atomic boundaries where straddling it fails to be an
atomic operation. Instead of removing the checks, you'd have to replace
it with a more costly operation if you really want to support more
arbitrary write lengths and offsets. And if you do manage to remove the
power of two requirement, then the queue limit for nvme's
atomic_write_hw_unit_max isn't correct anymore.
next prev parent reply other threads:[~2025-12-21 23:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-21 13:24 [PATCH v2] Do not require atomic writes to be power of 2 sized and aligned on length boundary Vitaliy Filippov
2025-12-21 23:17 ` Keith Busch [this message]
2025-12-22 9:54 ` Vitaliy Filippov
2025-12-22 13:28 ` Vitaliy Filippov
2025-12-23 9:26 ` John Garry
2025-12-23 11:19 ` Vitaliy Filippov
2025-12-23 11:34 ` Vitaliy Filippov
2026-01-28 6:08 ` Ojaswin Mujoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aUh_--eKRKYOHzLz@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=vitalifster@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox