Re: [PATCH 3/3] selftests/ublk: fix Makefile to rebuild on header changes

[Ming Lei <ming.lei@redhat.com>]

On Mon, Dec 22, 2025 at 11:48:37AM -0500, Caleb Sander Mateos wrote:
> On Sun, Dec 21, 2025 at 11:42 AM Ming Lei <ming.lei@redhat.com> wrote:
> >
> > Add header dependencies to kublk build rule so that changes to
> > kublk.h, ublk_dep.h, or utils.h trigger a rebuild.
> >
> > Signed-off-by: Ming Lei <ming.lei@redhat.com>
> > ---
> >  tools/testing/selftests/ublk/Makefile | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/tools/testing/selftests/ublk/Makefile b/tools/testing/selftests/ublk/Makefile
> > index eb0e6cfb00ad..fb7b2273e563 100644
> > --- a/tools/testing/selftests/ublk/Makefile
> > +++ b/tools/testing/selftests/ublk/Makefile
> > @@ -53,8 +53,10 @@ TEST_GEN_PROGS_EXTENDED = kublk
> >
> >  include ../lib.mk
> >
> > -$(TEST_GEN_PROGS_EXTENDED): kublk.c null.c file_backed.c common.c stripe.c \
> > -       fault_inject.c
> > +LOCAL_HDRS += kublk.h ublk_dep.h utils.h
> > +
> > +$(TEST_GEN_PROGS_EXTENDED): $(LOCAL_HDRS) \
> > +       kublk.c null.c file_backed.c common.c stripe.c fault_inject.c
> 
> I'm not really familiar with the selftests Makefile magic, but will
> this end up passing the header files as source files to the cc command
> too? That seems a bit wasteful, but probably won't cause any

I won't do this way, just setup build dependency on local header, please
see `$(OUTPUT)/%:%.c $(LOCAL_HDRS)` in `../lib.mk`.

> compilation failures. Maybe it would be better to explicitly list the
> .c files to pass to the cc command, which seems to be what most of the
> other selftests do.

It can be done in the following way:

diff --git a/tools/testing/selftests/ublk/Makefile b/tools/testing/selftests/ublk/Makefile
index eb0e6cfb00ad..06ba6fde098d 100644
--- a/tools/testing/selftests/ublk/Makefile
+++ b/tools/testing/selftests/ublk/Makefile
@@ -51,10 +51,10 @@ TEST_PROGS += test_stress_07.sh

 TEST_GEN_PROGS_EXTENDED = kublk

+LOCAL_HDRS += $(wildcard *.h)
 include ../lib.mk

-$(TEST_GEN_PROGS_EXTENDED): kublk.c null.c file_backed.c common.c stripe.c \
-       fault_inject.c
+$(TEST_GEN_PROGS_EXTENDED): $(wildcard *.c)

 check:
        shellcheck -x -f gcc *.sh


Thanks,
Ming