Re: [PATCH v2 1/2] ublk: make ublk_ctrl_stop_dev return void

[Ming Lei <ming.lei@redhat.com>]

On Sun, Jan 04, 2026 at 10:48:38AM +0200, Yoav Cohen wrote:
> This function always returns 0, so there is no need to return a value.
> 
> Signed-off-by: Yoav Cohen <yoav@nvidia.com>
> ---
>  drivers/block/ublk_drv.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c
> index 837fedb02e0d..2d5602ef05cc 100644
> --- a/drivers/block/ublk_drv.c
> +++ b/drivers/block/ublk_drv.c
> @@ -3304,10 +3304,9 @@ static inline void ublk_ctrl_cmd_dump(struct io_uring_cmd *cmd)
>  			header->data[0], header->addr, header->len);
>  }
>  
> -static int ublk_ctrl_stop_dev(struct ublk_device *ub)
> +static void ublk_ctrl_stop_dev(struct ublk_device *ub)
>  {
>  	ublk_stop_dev(ub);
> -	return 0;
>  }
>  
>  static int ublk_ctrl_get_dev_info(struct ublk_device *ub,
> @@ -3780,7 +3779,8 @@ static int ublk_ctrl_uring_cmd(struct io_uring_cmd *cmd,
>  		ret = ublk_ctrl_start_dev(ub, header);
>  		break;
>  	case UBLK_CMD_STOP_DEV:
> -		ret = ublk_ctrl_stop_dev(ub);
> +		ublk_ctrl_stop_dev(ub);
> +		ret = 0;

Reviewed-by: Ming Lei <ming.lei@redhat.com>


Thanks
Ming