public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Seamus Connor <sconnor@purestorage.com>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org,
	Caleb Sander Mateos <csander@purestorage.com>
Subject: Re: [PATCH v2] ublk: fix ublksrv pid handling for pid namespaces
Date: Wed, 14 Jan 2026 11:55:00 +0800	[thread overview]
Message-ID: <aWcTlFbYh7LbDLf2@fedora> (raw)
In-Reply-To: <CAB5MrP7M4TU+Y87QyM25kcqWX-mCzkdgWMn_CrB0oT=1aA1AJA@mail.gmail.com>

On Tue, Jan 13, 2026 at 03:03:04PM -0800, Seamus Connor wrote:
> Hi Ming,
> 
> I did the following test. I updated kublk.c so that getpid() could be
> overridden with arbitrary values. I then added probes around the code
> change. I tested the behavior of the change with arbitrary negative,
> and positive pids, confirming that I covered both pids that do exist,
> and pids that do not exist. The behavior of
> `pid_nr(find_vpid(ublksrv_pid));` is correct under these
> circumstances.
> 
> Of course, I am happy to add explicit checks, move to a helper, or add
> the tests I mentioned to the suite. Let me know.

Hi Seamus,

Please go ahead and post V3.

Thanks,
Ming


  reply	other threads:[~2026-01-14  3:55 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-11  0:00 [PATCH] ublk: fix ublksrv pid handling for pid namespaces Seamus Connor
2026-01-12  5:40 ` Ming Lei
2026-01-12 18:09   ` Seamus Connor
2026-01-12 22:56 ` [PATCH v2] " Seamus Connor
2026-01-13  2:01   ` Ming Lei
2026-01-13  2:46     ` Seamus Connor
2026-01-13  3:47       ` Ming Lei
2026-01-13 23:03         ` Seamus Connor
2026-01-14  3:55           ` Ming Lei [this message]
2026-01-14 20:47   ` [PATCH v3] " Seamus Connor
2026-01-15  1:48     ` Ming Lei
2026-01-15  2:59 ` [PATCH v4] " Seamus Connor
2026-01-20 23:48   ` Seamus Connor
2026-01-21 14:45   ` Jens Axboe
2026-01-21 14:48   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aWcTlFbYh7LbDLf2@fedora \
    --to=ming.lei@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=csander@purestorage.com \
    --cc=linux-block@vger.kernel.org \
    --cc=sconnor@purestorage.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox