Re: [PATCH blktests v6 1/3] check,common,srp/rc: replace module removal with patient module removal

[Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>]

On Jan 12, 2026 / 17:03, Bart Van Assche wrote:
> On 1/10/26 2:16 AM, Shin'ichiro Kawasaki wrote:
> > diff --git a/tests/srp/rc b/tests/srp/rc
> > index 47b9546..517733f 100755
> > --- a/tests/srp/rc
> > +++ b/tests/srp/rc
> > @@ -336,14 +336,14 @@ stop_srp_ini() {
> >   	log_out
> >   	for ((i=40;i>=0;i--)); do
> >   		remove_mpath_devs || return $?
> > -		_unload_module ib_srp >/dev/null 2>&1 && break
> > +		_patient_rmmod ib_srp >/dev/null 2>&1 && break
> >   		sleep 1
> >   	done
> 
> I don't think that this change is useful since there is a sleep statement
> just below the rmmod call. This change unnecessarily slows
> down this loop.
> 
> >   	if [ -e /sys/module/ib_srp ]; then
> >   		echo "Error: unloading kernel module ib_srp failed"
> >   		return 1
> >   	fi
> > -	_unload_module scsi_transport_srp || return $?
> > +	_patient_rmmod scsi_transport_srp || return $?
> >   }
> 
> This change shouldn't be necessary. Once the ib_srp kernel module
> has been unloaded, unloading scsi_transport_srp should succeed.

I see, I will drop the hunks above in the next spin. Thanks.