Re: [PATCH blktests 2/2] block/042: check sysfs values prior to running

[Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>]

On Jan 14, 2026 / 16:08, John Pittman wrote:
> In testing some older kernels recently, block/042 has failed due
> to dma_alignment and virt_boundary_mask not being present.
> 
>    Running block/042
>    +cat: '.../queue/dma_alignment': No such file or directory
>    +cat: '.../queue/virt_boundary_mask': No such file or directory
>    +dio-offsets: test_dma_aligned: failed to write buf: Invalid argument
> 
> To ensure we skip if this is the case, check all sysfs values prior
> to run.
> 
> Signed-off-by: John Pittman <jpittman@redhat.com>

John, thank you for this series.

> ---
>  tests/block/042 | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/block/042 b/tests/block/042
> index 28ac4a2..bbf13fd 100644
> --- a/tests/block/042
> +++ b/tests/block/042
> @@ -11,7 +11,9 @@ DESCRIPTION="Test unusual direct-io offsets"
>  QUICK=1
>  
>  device_requires() {
> -        _require_test_dev_sysfs
> +        _require_test_dev_sysfs "" "queue/max_segments" "queue/dma_alignment" \

Do we need the first argument "" ?  It looks useless.
Nit: spaces are used for indent. I suggest to replace them with a space.

> +		"queue/virt_boundary_mask" "queue/logical_block_size" \
> +		"queue/max_sectors_kb"
>  }
>  
>  test_device() {
> -- 
> 2.51.1
>