public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] selftests: ublk: add missing gitignore for metadata_size binary
@ 2026-01-25  8:57 Alexander Atanasov
  2026-01-25 14:25 ` Ming Lei
  2026-01-25 17:12 ` Jens Axboe
  0 siblings, 2 replies; 3+ messages in thread
From: Alexander Atanasov @ 2026-01-25  8:57 UTC (permalink / raw)
  To: Ming Lei, Shuah Khan, Jens Axboe, Caleb Sander Mateos
  Cc: Alexander Atanasov, linux-block, linux-kselftest, linux-kernel

A new utility metadata_size was added in
commit 261b67f4e347 ("selftests: ublk: add utility to get block device metadata size")
but it was not added to .gitignore. Fix that by adding it there.

While at it sort all entries alphabetically and add a SPDX license header.

Reviewed-by: Caleb Sander Mateos <csander@purestorage.com>
Fixes: 261b67f4e347 ("selftests: ublk: add utility to get block device metadata size")
Signed-off-by: Alexander Atanasov <alex@zazolabs.com>
---
 tools/testing/selftests/ublk/.gitignore | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

v1->v2:
 - add SPDX license header
 - sort alphabetically as suggested by Caleb Sander Mateos

It is also Reviewed-by: Ming Lei <ming.lei@redhat.com> but it needs an Ack from him,
as he is the original author of the file, for the license header.


diff --git a/tools/testing/selftests/ublk/.gitignore b/tools/testing/selftests/ublk/.gitignore
index 8b2871ea7751..e17bd28f27e0 100644
--- a/tools/testing/selftests/ublk/.gitignore
+++ b/tools/testing/selftests/ublk/.gitignore
@@ -1,3 +1,5 @@
-kublk
-/tools
+# SPDX-License-Identifier: GPL-2.0
 *-verify.state
+/tools
+kublk
+metadata_size
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] selftests: ublk: add missing gitignore for metadata_size binary
  2026-01-25  8:57 [PATCH v2] selftests: ublk: add missing gitignore for metadata_size binary Alexander Atanasov
@ 2026-01-25 14:25 ` Ming Lei
  2026-01-25 17:12 ` Jens Axboe
  1 sibling, 0 replies; 3+ messages in thread
From: Ming Lei @ 2026-01-25 14:25 UTC (permalink / raw)
  To: Alexander Atanasov
  Cc: Shuah Khan, Jens Axboe, Caleb Sander Mateos, linux-block,
	linux-kselftest, linux-kernel

On Sun, Jan 25, 2026 at 08:57:46AM +0000, Alexander Atanasov wrote:
> A new utility metadata_size was added in
> commit 261b67f4e347 ("selftests: ublk: add utility to get block device metadata size")
> but it was not added to .gitignore. Fix that by adding it there.
> 
> While at it sort all entries alphabetically and add a SPDX license header.
> 
> Reviewed-by: Caleb Sander Mateos <csander@purestorage.com>
> Fixes: 261b67f4e347 ("selftests: ublk: add utility to get block device metadata size")
> Signed-off-by: Alexander Atanasov <alex@zazolabs.com>
> ---
>  tools/testing/selftests/ublk/.gitignore | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> v1->v2:
>  - add SPDX license header
>  - sort alphabetically as suggested by Caleb Sander Mateos
> 
> It is also Reviewed-by: Ming Lei <ming.lei@redhat.com> but it needs an Ack from him,
> as he is the original author of the file, for the license header.
> 
> 
> diff --git a/tools/testing/selftests/ublk/.gitignore b/tools/testing/selftests/ublk/.gitignore
> index 8b2871ea7751..e17bd28f27e0 100644
> --- a/tools/testing/selftests/ublk/.gitignore
> +++ b/tools/testing/selftests/ublk/.gitignore
> @@ -1,3 +1,5 @@
> -kublk
> -/tools
> +# SPDX-License-Identifier: GPL-2.0
>  *-verify.state
> +/tools
> +kublk
> +metadata_size

Reviewed-by: Ming Lei <ming.lei@redhat.com>


Thanks,
Ming


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] selftests: ublk: add missing gitignore for metadata_size binary
  2026-01-25  8:57 [PATCH v2] selftests: ublk: add missing gitignore for metadata_size binary Alexander Atanasov
  2026-01-25 14:25 ` Ming Lei
@ 2026-01-25 17:12 ` Jens Axboe
  1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2026-01-25 17:12 UTC (permalink / raw)
  To: Ming Lei, Shuah Khan, Caleb Sander Mateos, Alexander Atanasov
  Cc: linux-block, linux-kselftest, linux-kernel


On Sun, 25 Jan 2026 08:57:46 +0000, Alexander Atanasov wrote:
> A new utility metadata_size was added in
> commit 261b67f4e347 ("selftests: ublk: add utility to get block device metadata size")
> but it was not added to .gitignore. Fix that by adding it there.
> 
> While at it sort all entries alphabetically and add a SPDX license header.
> 
> 
> [...]

Applied, thanks!

[1/1] selftests: ublk: add missing gitignore for metadata_size binary
      commit: 8e5bcc3a955a2cc4460b391f55d3b49905eb248e

Best regards,
-- 
Jens Axboe




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-01-25 17:12 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-25  8:57 [PATCH v2] selftests: ublk: add missing gitignore for metadata_size binary Alexander Atanasov
2026-01-25 14:25 ` Ming Lei
2026-01-25 17:12 ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox