From: Christoph Hellwig <hch@infradead.org>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org
Subject: Re: [PATCH 2/2] block: introduce blk_queue_rot()
Date: Thu, 29 Jan 2026 21:42:08 -0800 [thread overview]
Message-ID: <aXxEsA_HMLxLORZV@infradead.org> (raw)
In-Reply-To: <20260129072715.1107336-3-dlemoal@kernel.org>
On Thu, Jan 29, 2026 at 04:27:15PM +0900, Damien Le Moal wrote:
> To check if a request queue is for a rotational device, a double
> negation is needed with the pattern "!blk_queue_nonrot(q)". Simplify
> this with the introduction of the helper blk_queue_rot() which tests
> if a requests queue limit has the BLK_FEAT_ROTATIONAL feature set.
> All call sites of blk_queue_nonrot() are modified to use blk_queue_rot()
> and blk_queue_nonrot() definition removed.
Looks good, and I should have done that soon after inverting the
underlying flag:
Reviewed-by: Christoph Hellwig <hch@lst.de>
We should also do the same with bdev_nonrot, maybe staged because
of a lot of callers outside the block code.
next prev parent reply other threads:[~2026-01-30 5:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-29 7:27 [PATCH 0/2] Cleanup patches Damien Le Moal
2026-01-29 7:27 ` [PATCH 1/2] block: cleanup queue limit features definition Damien Le Moal
2026-01-29 9:22 ` Nitesh Shetty
2026-01-29 11:52 ` John Garry
2026-01-30 5:40 ` Christoph Hellwig
2026-01-29 7:27 ` [PATCH 2/2] block: introduce blk_queue_rot() Damien Le Moal
2026-01-29 9:18 ` Nitesh Shetty
2026-01-29 9:38 ` Damien Le Moal
2026-01-29 9:44 ` Nitesh Shetty
2026-01-30 5:42 ` Christoph Hellwig [this message]
2026-01-30 5:50 ` Damien Le Moal
2026-01-30 5:53 ` Christoph Hellwig
2026-01-30 5:55 ` Damien Le Moal
2026-01-29 18:19 ` [PATCH 0/2] Cleanup patches Martin K. Petersen
2026-01-29 20:17 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXxEsA_HMLxLORZV@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox