Re: [PATCH 2/2] block: introduce blk_queue_rot()

[Christoph Hellwig <hch@infradead.org>]

On Fri, Jan 30, 2026 at 02:50:12PM +0900, Damien Le Moal wrote:
> On 1/30/26 14:42, Christoph Hellwig wrote:
> > On Thu, Jan 29, 2026 at 04:27:15PM +0900, Damien Le Moal wrote:
> >> To check if a request queue is for a rotational device, a double
> >> negation is needed with the pattern "!blk_queue_nonrot(q)". Simplify
> >> this with the introduction of the helper blk_queue_rot() which tests
> >> if a requests queue limit has the BLK_FEAT_ROTATIONAL feature set.
> >> All call sites of blk_queue_nonrot() are modified to use blk_queue_rot()
> >> and blk_queue_nonrot() definition removed.
> > 
> > Looks good, and I should have done that soon after inverting the
> > underlying flag:
> > 
> > Reviewed-by: Christoph Hellwig <hch@lst.de>
> > 
> > We should also do the same with bdev_nonrot, maybe staged because
> > of a lot of callers outside the block code.
> 
> Yes, that is why I did not send a patch for that one as the changes are mostly
> in file systems. Will send something later.

It might be a good idea to just add it and use in "block tree" code,
and then we can convert other callers in the next merge window and
eventually kill off bdev_nonrot.