Re: [PATCH blktests v2] nvme/067: test io_uring pass through for NVMe admin queue

[Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>]

On Feb 02, 2026 / 11:26, sw.prabhu6@gmail.com wrote:
> From: Swarna Prabhu <s.prabhu@samsung.com>
> 
> Simple test to exercise the nvme admin commands usage with
> io uring passthrough interfaces. The motivation for the test
> is to extend the kernel code coverage for NVMe admin commands
> via io_uring passthrough.
> 
> Signed-off-by: Swarna Prabhu <s.prabhu@samsung.com>

Thanks for this v2 patch. I applied it. FYI, I took a liberty to fold-in
some edits below:

...

> diff --git a/src/Makefile b/src/Makefile
> index dac07c7..bd94636 100644
> --- a/src/Makefile
> +++ b/src/Makefile
[...]
> +	if (cqe)
> +		io_uring_cqe_seen(&nvring, cqe);
> +	io_uring_queue_exit(&nvring);
> +free_nctrl:
> +	free(nctrl);
> +free_fd:
> +        close(fd);

I replaced space indent above with a tab.

> +
> +	return ret;
> +}
> \ No newline at end of file
> diff --git a/tests/nvme/067 b/tests/nvme/067
> new file mode 100755
> index 0000000..38d55ad
> --- /dev/null
> +++ b/tests/nvme/067
[...]
> +test_device() {
> +	echo "Running ${TEST_NAME}"

I added local variable declarations for devname and ctrl_dev here.

> +
> +	# extract the ctrl dev from the test dev
> +	devname=${TEST_DEV#/dev/}
> +	ctrl_dev="/dev/${devname%n*}"
> +
> +	# enable io_uring when it is disabled
> +	_io_uring_enable
> +
> +	if ! sudo src/nvme-passthrough-admin "${ctrl_dev}"; then
> +		echo "src/nvme-passthrough-admin failed"

I replaced the program names "src/nvme-passthrough-admin" above with
"src/nvme-passthru-admin-uring".

Thanks again for the contribution!