From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0338ECAAA3 for ; Fri, 26 Aug 2022 11:26:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245290AbiHZL01 (ORCPT ); Fri, 26 Aug 2022 07:26:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245078AbiHZL00 (ORCPT ); Fri, 26 Aug 2022 07:26:26 -0400 Received: from out0.migadu.com (out0.migadu.com [IPv6:2001:41d0:2:267::]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6941FB99C1; Fri, 26 Aug 2022 04:26:25 -0700 (PDT) Subject: Re: [PATCH] rnbd-srv: remove 'dir' argument from rnbd_srv_rdma_ev DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1661513183; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EDEDV4Za64xDzQejgmqdr6o7gDUf8GyuO67eOl/XmIw=; b=jZ82XdsCkOAy3b15Wj2VsWsqM4CIjUk99LoWDmayYcRgsWLQSZ1wc/Qmv60OtwJOt7yPXX CQpPpcPghXIf6G2SqW48TKbbcc5tHe+14XR5BlPPy/zCmqEnmiJFRGmKsImdSGuS0/O1sJ gfB4+2hKVlPcoufwzaU4v6GNoa52Ka4= To: Jinpu Wang Cc: haris.iqbal@ionos.com, axboe@kernel.dk, jgg@ziepe.ca, leon@kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org References: <20220826081117.21687-1-guoqing.jiang@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Guoqing Jiang Message-ID: Date: Fri, 26 Aug 2022 19:26:17 +0800 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 8/26/22 6:48 PM, Jinpu Wang wrote: > On Fri, Aug 26, 2022 at 10:11 AM Guoqing Jiang wrote: >> Since all callers (process_{read,write}) set id->dir, no need to >> pass 'dir' again. >> >> Signed-off-by: Guoqing Jiang >> --- >> drivers/block/rnbd/rnbd-srv.c | 9 ++++----- >> drivers/block/rnbd/rnbd-srv.h | 1 + >> drivers/infiniband/ulp/rtrs/rtrs-srv.c | 4 ++-- >> drivers/infiniband/ulp/rtrs/rtrs.h | 3 +-- >> 4 files changed, 8 insertions(+), 9 deletions(-) >> >> diff --git a/drivers/block/rnbd/rnbd-srv.c b/drivers/block/rnbd/rnbd-srv.c >> index 3f6c268e04ef..9600715f1029 100644 >> --- a/drivers/block/rnbd/rnbd-srv.c >> +++ b/drivers/block/rnbd/rnbd-srv.c >> @@ -368,10 +368,9 @@ static int process_msg_sess_info(struct rnbd_srv_session *srv_sess, >> const void *msg, size_t len, >> void *data, size_t datalen); >> >> -static int rnbd_srv_rdma_ev(void *priv, >> - struct rtrs_srv_op *id, int dir, >> - void *data, size_t datalen, const void *usr, >> - size_t usrlen) >> +static int rnbd_srv_rdma_ev(void *priv, struct rtrs_srv_op *id, >> + void *data, size_t datalen, >> + const void *usr, size_t usrlen) >> { >> struct rnbd_srv_session *srv_sess = priv; >> const struct rnbd_msg_hdr *hdr = usr; >> @@ -398,7 +397,7 @@ static int rnbd_srv_rdma_ev(void *priv, >> break; >> default: >> pr_warn("Received unexpected message type %d with dir %d from session %s\n", >> - type, dir, srv_sess->sessname); >> + type, id->dir, srv_sess->sessname); >> return -EINVAL; >> } >> >> diff --git a/drivers/block/rnbd/rnbd-srv.h b/drivers/block/rnbd/rnbd-srv.h >> index 081bceaf4ae9..5a0ef6c2b5c7 100644 >> --- a/drivers/block/rnbd/rnbd-srv.h >> +++ b/drivers/block/rnbd/rnbd-srv.h >> @@ -14,6 +14,7 @@ >> #include >> >> #include >> +#include > why do we need this? Otherwise, compiler complains drivers/block/rnbd/rnbd-srv.c: In function ‘rnbd_srv_rdma_ev’: drivers/block/rnbd/rnbd-srv.c:400:33: error: invalid use of undefined type ‘struct rtrs_srv_op’   400 |                         type, id->dir, srv_sess->sessname); Thanks, Guoqing