Re: [PATCH v2 2/4] selftests: ublk: rework partitions tests for new flags

[Ming Lei <ming.lei@redhat.com>]

On Fri, Feb 27, 2026 at 02:57:54PM +0000, Alexander Atanasov wrote:
> To support new flag - UBLK_F_NO_PARTITIONS
> add kublk argument:
> -m, --no_partitions - disable partitions on trusted devices
> Add short argument for  UBLK_F_NO_AUTO_PART_SCAN
> -p, --no_auto_part_scan - disable initial partition scan
> 
> Update test cases to use the new arguments
> 
> Fix long lines while at it.
> 
> Signed-off-by: Alexander Atanasov <alex@zazolabs.com>
> ---
>  tools/testing/selftests/ublk/kublk.c             | 16 +++++++++++-----
>  .../testing/selftests/ublk/test_integrity_01.sh  |  8 +++++---
>  tools/testing/selftests/ublk/test_part_01.sh     |  6 +++---
>  tools/testing/selftests/ublk/test_part_02.sh     |  6 ++++--
>  4 files changed, 23 insertions(+), 13 deletions(-)
> 
> v1->v2:
>   - switch from opt-in to opt-out flags
> 
> diff --git a/tools/testing/selftests/ublk/kublk.c b/tools/testing/selftests/ublk/kublk.c
> index e8279c4acc40..c0dacdc12ebe 100644
> --- a/tools/testing/selftests/ublk/kublk.c
> +++ b/tools/testing/selftests/ublk/kublk.c
> @@ -1615,6 +1615,7 @@ static int cmd_dev_get_features(void)
>  		FEAT_NAME(UBLK_F_INTEGRITY),
>  		FEAT_NAME(UBLK_F_SAFE_STOP_DEV),
>  		FEAT_NAME(UBLK_F_BATCH_IO),
> +		FEAT_NAME(UBLK_F_NO_PARTITIONS),
>  		FEAT_NAME(UBLK_F_NO_AUTO_PART_SCAN),
>  	};
>  	struct ublk_dev *dev;
> @@ -1713,7 +1714,7 @@ static void __cmd_create_help(char *exe, bool recovery)
>  	printf("\t[--nthreads threads] [--per_io_tasks]\n");
>  	printf("\t[--integrity_capable] [--integrity_reftag] [--metadata_size SIZE] "
>  		 "[--pi_offset OFFSET] [--csum_type ip|t10dif|nvme] [--tag_size SIZE]\n");
> -	printf("\t[--batch|-b] [--no_auto_part_scan]\n");
> +	printf("\t[--batch|-b] [-m,--no_partitions] [-p,--no_auto_part_scan]\n");
>  	printf("\t[target options] [backfile1] [backfile2] ...\n");
>  	printf("\tdefault: nr_queues=2(max 32), depth=128(max 1024), dev_id=-1(auto allocation)\n");
>  	printf("\tdefault: nthreads=nr_queues");
> @@ -1783,11 +1784,12 @@ int main(int argc, char *argv[])
>  		{ "integrity_reftag",	0,	NULL,  0 },
>  		{ "metadata_size",	1,	NULL,  0 },
>  		{ "pi_offset",		1,	NULL,  0 },
> +		{ "no_partitions",	0,	NULL, 'm' },
> +		{ "no_auto_part_scan",	0,	NULL, 'p' },

IMO, both two short options('m' and 'p') are not readable, I'd suggest to
not add short option if better name can't be figured out.

Otherwise, this patch looks fine.


thanks,
Ming