From: Benjamin Marzinski <bmarzins@redhat.com>
To: John Garry <john.g.garry@oracle.com>
Cc: Ewan Milne <emilne@redhat.com>, Hannes Reinecke <hare@suse.de>,
Mike Snitzer <snitzer@kernel.org>,
lsf-pc@lists.linux-foundation.org,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
linux-scsi@vger.kernel.org, dm-devel@lists.linux.dev
Subject: Re: [LSF/MM/BPF TOPIC] Native SCSI multipath support
Date: Tue, 10 Mar 2026 14:42:29 -0400 [thread overview]
Message-ID: <abBmFZY9PhGoZu7o@redhat.com> (raw)
In-Reply-To: <949c3319-1938-410e-8796-8e8bbdf59103@oracle.com>
On Tue, Mar 10, 2026 at 06:05:29PM +0000, John Garry wrote:
> On 10/03/2026 17:12, Ewan Milne wrote:
> > Hi John-
> >
> > Sorry, I was out for a couple of weeks and have been catching up...
> >
> > Re: sg support, there were issues in the past with people attempting
> > to do SG_IO through dm-mp
> > assuming that DM would handle retry on other paths, which it didn't.
> > You also have to be aware
> > that non-idempotent commands don't work right if retried. My
> > recommendation would be to avoid
> > implementing it, although there has been interest in a better way to
> > do multipathed "generic"
> > commands (e.g. virt pass-through) I think that is a more involved
> > project than you want to do here.
>
> Understood, my current plan is not have a multipathed sg driver - we will
> still have the per-scsi device/path sg device.
The sd devices still handle SG_IO ioctls. For instance, the persistent
reservation ioctls are SG_IO ioctls. But like I said elsewhere, getting
multipathed persistent reservations working safely is going to be a
large effort, better left for later.
But even without them, to handle things like sending SCSI WRITE commands
over SG_IO ioctls, in an ideal world, you would want to be able to retry
on other paths in the ioctl code. However, like Ewan mentioned, there
are times when you don't want to retry the ioctl. Just sending SG_IO
ioctls to one path and letting them fail if they fail down that path is
the safest way for now, even if there are times when that SG_IO ioctl
could complete successfully down another path.
-Ben
>
> >
> > I see the discussion has progressed re: ALUA support in your later
> > patch postings, which is good.
> > As Hannes said, a Native SCSI MP would be useless without it. You
> > don't have to support the
> > older non-ALUA mechanisms though, those arrays are way, way old.
> >
> > SCSI does not have the equivalent of NVMe's AEN, so you need a way to
> > ensure that your
> > ALUA info is up-to-date. DM-MP's path checker normally does this by
> > sending commands on
> > which the Unit Attention can be reported so that the code can fetch
> > up-to-date ALUA info.
> > Hannes made some optimizations years ago to avoid excessive RTPG
> > commands with large
> > numbers of LUNs which we would need also.
>
> Hannes is suggesting to not have a kernel path checker, so let me know if
> any issue with that.
>
> >
> > It will be necessary for the functionality to be enabled via a module
> > option, at least initially.
> > Introducing this in general use will be a big change for people who
> > have Enterprise SAN
> > configurations with their own custom path monitoring tools. I believe
> > we put some functionality
> > into usespace multipath tools so e.g. Native NVMe devices can still be
> > monitored/observed
> > which made things a bit easier for people.
> >
>
> Sure, if you check my patches, we disable by default and enable via a module
> param
>
> cheers
prev parent reply other threads:[~2026-03-10 18:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-13 14:19 [LSF/MM/BPF TOPIC] Native SCSI multipath support John Garry
2026-02-13 17:21 ` Hannes Reinecke
2026-02-14 9:42 ` John Garry
2026-02-16 7:26 ` Hannes Reinecke
2026-02-16 16:32 ` Hannes Reinecke
2026-02-16 16:55 ` John Garry
2026-02-17 7:05 ` Hannes Reinecke
2026-02-21 17:47 ` Mike Snitzer
2026-02-17 19:33 ` Bart Van Assche
2026-02-17 20:13 ` Keith Busch
2026-02-18 2:39 ` [Lsf-pc] " Martin K. Petersen
2026-02-18 7:35 ` Hannes Reinecke
2026-02-18 8:35 ` John Garry
2026-02-18 8:23 ` John Garry
2026-02-21 17:41 ` Mike Snitzer
2026-02-24 9:56 ` John Garry
2026-02-25 0:46 ` Benjamin Marzinski
2026-02-25 8:11 ` Hannes Reinecke
2026-02-25 9:26 ` John Garry
2026-03-10 17:12 ` Ewan Milne
2026-03-10 18:05 ` John Garry
2026-03-10 18:42 ` Benjamin Marzinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abBmFZY9PhGoZu7o@redhat.com \
--to=bmarzins@redhat.com \
--cc=dm-devel@lists.linux.dev \
--cc=emilne@redhat.com \
--cc=hare@suse.de \
--cc=john.g.garry@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=lsf-pc@lists.linux-foundation.org \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox