From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f73.google.com (mail-wr1-f73.google.com [209.85.221.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4051830CD82 for ; Mon, 16 Mar 2026 10:40:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773657639; cv=none; b=iw+26hm6HtZK+g1cDCzjqO9LPz13ipsl8PlZO6o1wVJVGq4P5sEyod8zB6lGW4BAaWiU7KwVEdgt0uWk3LV/kEP90EsxAQho1JNNke8jMWImq1CvSSskmQle7zTr+wznmGygsaLpR0XIeIihQKEjX3ifbhaOUXaAL3X4z4r4fh4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773657639; c=relaxed/simple; bh=QX1AcmRboNh8rJ6OkuWmVoguzp3UVXGEe0/7F55dKL4=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=Aef7QvYS4RNgirn0Ut+L1V7F3PWx7s9N4j/dkW99tKINk696SOBMvCoPWEzMvhYz5lmVHgfUpgpE7DVinsPzs6rpE27MZB8XXQI15UIOHy4b5oT6EK4bBueran+l1MY08z82Ch8UeH29WHY50zekDB2yvWX8KNn+iYIGLZUKGr0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=STOZEUXq; arc=none smtp.client-ip=209.85.221.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="STOZEUXq" Received: by mail-wr1-f73.google.com with SMTP id ffacd0b85a97d-439c794ec8eso4250578f8f.1 for ; Mon, 16 Mar 2026 03:40:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1773657636; x=1774262436; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=KKz2KTzlcBf86rOKf9vSTqBmxmc8gj/65J7dXuwwtTQ=; b=STOZEUXqrAFGEz0vNuAYL0/zqXYABovI9JSGxZytPrvjs417L5R6YgBQlrUQO2pehB PPKDCb66Oe4pAhMjYCw7mQjAywa3vqVesdzVzltpqRxlNXhh2VziXoATFCELc/uEKSOA fHNUEtR4BHmzmD5ezJH3Vl8soaqmzKOzQKtf893xB4p1c0da9AzqyCqFWU30msrLXdQr zaoIPl/BOqLwx98akudU8tnjgivyf9AZGfpZZ9d7bReV2meol/I77Z0OGpQvpu/YZBvm SkYE2ww67/ikJX38ImsAvnqf93kFJjn0+FgYg4LA8CApm2mEe4By9qpgy12QxQib8Zy7 qogw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773657636; x=1774262436; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KKz2KTzlcBf86rOKf9vSTqBmxmc8gj/65J7dXuwwtTQ=; b=BVcxIyM8ga/2eDJeqAeeDiDwNTH4SmFf4QaBMPGkAJ2iLV2fipgEgQw+mCEDSWLV1S INZGNbe6ymr02gE2EwztwF2LuX0JM2l5gcqS07wsrKMpTm5IO8yN6P+fhObgmRPJBUx5 /eJ59fqyWxx+xY5zbAK52A0TMBfhdHux3LCNmilhitJdvEHyLwnUUQHvuyRTpWBB/Q/O +IawlwsKAGkunB9Dw6eAeujOiuiWvLeN1SYb72jHUIh18z+Iq4IWjXLsAXJvBA3wPtBs l5B1OEqhQ2tvsNF0FnYN8c+tRwvX2IAbsifik9UPv59ZbdthIpi7G7RFA+mD6sz7iVux LRQQ== X-Forwarded-Encrypted: i=1; AJvYcCWIzYIEpJnFLqyVq4rj3IeaQnJVrOe9+cVBGebO082isXAoh0KwRuQe7VidGMH4CYgalCTagUjMVW0QLw==@vger.kernel.org X-Gm-Message-State: AOJu0Yw3zBaDBxqEGkjDki4ZHUSkz5ycQgqCXNNf0Sqssvdfhx4k4ErF YeNEWphKpATCaw+ZY53+5AnN6ee0nEv46qFaDXxGPpk9A/Qdhq03o4KMN9uj09xUsKb4upBN8Af CyNDoVMn2W62l02nweQ== X-Received: from wrbbs28.prod.google.com ([2002:a05:6000:71c:b0:439:cc48:d5]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6000:26c2:b0:43b:433f:489c with SMTP id ffacd0b85a97d-43b433f4a72mr6008387f8f.13.1773657635312; Mon, 16 Mar 2026 03:40:35 -0700 (PDT) Date: Mon, 16 Mar 2026 10:40:34 +0000 In-Reply-To: <20260216-rnull-v6-19-rc5-send-v1-14-de9a7af4b469@kernel.org> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260216-rnull-v6-19-rc5-send-v1-0-de9a7af4b469@kernel.org> <20260216-rnull-v6-19-rc5-send-v1-14-de9a7af4b469@kernel.org> Message-ID: Subject: Re: [PATCH 14/79] block: rnull: add submit queue count config option From: Alice Ryhl To: Andreas Hindborg Cc: Boqun Feng , Jens Axboe , Miguel Ojeda , Gary Guo , "=?utf-8?B?QmrDtnJu?= Roy Baron" , Benno Lossin , Trevor Gross , Danilo Krummrich , FUJITA Tomonori , Frederic Weisbecker , Lyude Paul , Thomas Gleixner , Anna-Maria Behnsen , John Stultz , Stephen Boyd , Lorenzo Stoakes , "Liam R. Howlett" , linux-block@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="utf-8" On Mon, Feb 16, 2026 at 12:35:01AM +0100, Andreas Hindborg wrote: > Allow user space to control the number of submission queues when creating > null block devices. > > Signed-off-by: Andreas Hindborg > --- > drivers/block/rnull/configfs.rs | 56 +++++++++++++++++++++++++++++++++-------- > drivers/block/rnull/rnull.rs | 56 +++++++++++++++++++++++++++-------------- > 2 files changed, 83 insertions(+), 29 deletions(-) > > diff --git a/drivers/block/rnull/configfs.rs b/drivers/block/rnull/configfs.rs > index b5dc30c5d3e20..fd3cbf7aa012e 100644 > --- a/drivers/block/rnull/configfs.rs > +++ b/drivers/block/rnull/configfs.rs > @@ -59,7 +59,10 @@ impl AttributeOperations<0> for Config { > > fn show(_this: &Config, page: &mut [u8; PAGE_SIZE]) -> Result { > let mut writer = kernel::str::Formatter::new(page); > - writer.write_str("blocksize,size,rotational,irqmode,completion_nsec,memory_backed\n")?; > + writer.write_str( > + "blocksize,size,rotational,irqmode,completion_nsec,memory_backed\ > + submit_queues\n", > + )?; Missing comma? If so, this may indicate missing test coverage :) > +struct NullBlkOptions<'a> { > + name: &'a CStr, > + block_size: u32, > + rotational: bool, > + capacity_mib: u64, > + irq_mode: IRQMode, > + completion_time: Delta, > + memory_backed: bool, > + submit_queues: u32, > +} > struct NullBlkDevice; > > impl NullBlkDevice { > - fn new( > - name: &CStr, > - block_size: u32, > - rotational: bool, > - capacity_mib: u64, > - irq_mode: IRQMode, > - completion_time: Delta, > - memory_backed: bool, > - ) -> Result> { > + fn new(options: NullBlkOptions<'_>) -> Result> { > + let NullBlkOptions { > + name, > + block_size, > + rotational, > + capacity_mib, > + irq_mode, > + completion_time, > + memory_backed, > + submit_queues, > + } = options; Nice! Alice