Linux block layer
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: Ming Lei <tom.leiming@gmail.com>, Christian Brauner <brauner@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
	Chris Mason <mason@kernel.org>
Subject: Re: ublk: consequences of a dead server are only failing on the last /dev/ublkcN release
Date: Mon, 21 Sep 2026 10:59:38 +0200	[thread overview]
Message-ID: <ad45110f-2497-43e7-9846-3e2dc56c6079@suse.de> (raw)
In-Reply-To: <aq_iJpAgRi9ZfnOg@fedora-laptop>

On 9/20/26 3:39 PM, Ming Lei wrote:
> Hello,
> 
> On Fri, Sep 18, 2026 at 12:29:22PM +0200, Christian Brauner wrote:
>> Hi,
>>
[ .. ]
>> The commit 7fc4da6a304b ("ublk: scan partition in async way") made
>> partition scans run from a workqueue that holds disk->open_mutex while
>> the server serves its reads and START_DEV returns before it's finished.
>>
>> Any server that treats START_DEV's return as a signal that the disk is
>> ready and doesn't serve requests hangs every open() of /dev/ublkbN on
>> uninterruptible on open_mutex. You can combine that with (1) and (2).
> 
> START_DEV doesn't promise partitions scanning done when it is returned.
> 
> nvme multipath has similar usage too.
> 
Indeed, we hit the same issue with nvme. We got it fixed by commit
1f021341eef41e77a633186e9be5223de2ce5d48 ('nvme-multipath: defer 
partition scanning'), essentially suppress partition scan during
probing, and move the partition scan to a work thread. That way
probing can continue (even if partition scan is blocked), and
a failed probe can correctly abort partition scanning.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@suse.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich

      reply	other threads:[~2026-09-21  8:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-18 10:29 ublk: consequences of a dead server are only failing on the last /dev/ublkcN release Christian Brauner
2026-09-18 16:34 ` Caleb Sander Mateos
2026-09-20 11:35   ` Ming Lei
2026-09-20 13:39 ` Ming Lei
2026-09-21  8:59   ` Hannes Reinecke [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ad45110f-2497-43e7-9846-3e2dc56c6079@suse.de \
    --to=hare@suse.de \
    --cc=axboe@kernel.dk \
    --cc=brauner@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=mason@kernel.org \
    --cc=tom.leiming@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox