From: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Damien Le Moal <dlemoal@kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH blktests] src/dio-offsets.c: Fix err() usage
Date: Tue, 7 Apr 2026 03:37:25 +0000 [thread overview]
Message-ID: <adR70_hLiVavpvK1@shinmob> (raw)
In-Reply-To: <020e64e2-8a2c-4e91-ac4e-21801fe5216f@acm.org>
On Apr 06, 2026 / 06:51, Bart Van Assche wrote:
> On 4/4/26 1:35 AM, Shinichiro Kawasaki wrote:
> > One thing I found is that one more err(EIO,...) is left in __compare() after
> > applying the patch. Should we convert it also into err_errno()? If so, I will
> > fold-in the hunk below.
> >
> > diff --git a/src/dio-offsets.c b/src/dio-offsets.c
> > index 9fc7b92..c40ce68 100644
> > --- a/src/dio-offsets.c
> > +++ b/src/dio-offsets.c
> > @@ -131,7 +131,7 @@ static void __compare(void *a, void *b, size_t size, const char *test)
> > {
> > if (!memcmp(a, b, size))
> > return;
> > - err(EIO, "%s: data corruption", test);
> > + err_errno(EIO, "%s: data corruption", test);
> > }
> > #define compare(a, b, size) __compare(a, b, size, __func__)
>
> Folding in this change sounds good to me.
Thanks for the response. I applied the patch folding in the change.
prev parent reply other threads:[~2026-04-07 3:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 17:36 [PATCH blktests] src/dio-offsets.c: Fix err() usage Bart Van Assche
2026-03-26 17:42 ` Keith Busch
2026-04-04 8:35 ` Shinichiro Kawasaki
2026-04-06 13:51 ` Bart Van Assche
2026-04-07 3:37 ` Shinichiro Kawasaki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adR70_hLiVavpvK1@shinmob \
--to=shinichiro.kawasaki@wdc.com \
--cc=bvanassche@acm.org \
--cc=dlemoal@kernel.org \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox