From: "Christoph Böhmwalder" <christoph.boehmwalder@linbit.com>
To: David Carlier <devnexen@gmail.com>
Cc: Philipp Reisner <philipp.reisner@linbit.com>,
Lars Ellenberg <lars.ellenberg@linbit.com>,
Jens Axboe <axboe@kernel.dk>,
drbd-dev@lists.linbit.com, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] drbd: use get_random_u64() where appropriate
Date: Tue, 7 Apr 2026 13:03:14 +0200 [thread overview]
Message-ID: <adTj5DBxjUjVkx82@localhost.localdomain> (raw)
In-Reply-To: <20260405154704.4610-1-devnexen@gmail.com>
On Sun, Apr 05, 2026 at 04:47:04PM +0100, David Carlier wrote:
>Use the typed random integer helpers instead of
>get_random_bytes() when filling a single integer variable.
>The helpers return the value directly, require no pointer
>or size argument, and better express intent.
>
>Signed-off-by: David Carlier <devnexen@gmail.com>
>---
> drivers/block/drbd/drbd_main.c | 4 ++--
> drivers/block/drbd/drbd_nl.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
Maybe I just missed it, but v1 and v2 of this don't seem to exist?
Anyway, the patch itself looks good, thanks.
Reviewed-by: Christoph Böhmwalder <christoph.boehmwalder@linbit.com>
next prev parent reply other threads:[~2026-04-07 11:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-05 15:47 [PATCH v3] drbd: use get_random_u64() where appropriate David Carlier
2026-04-07 11:03 ` Christoph Böhmwalder [this message]
2026-04-07 12:27 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adTj5DBxjUjVkx82@localhost.localdomain \
--to=christoph.boehmwalder@linbit.com \
--cc=axboe@kernel.dk \
--cc=devnexen@gmail.com \
--cc=drbd-dev@lists.linbit.com \
--cc=lars.ellenberg@linbit.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=philipp.reisner@linbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox