From: Christoph Hellwig <hch@infradead.org>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>, Carlos Maiolino <cem@kernel.org>,
Bart Van Assche <bvanassche@acm.org>,
linux-block@vger.kernel.org, linux-xfs@vger.kernel.org,
kbusch@kernel.org
Subject: Re: [PATCH 3/4] block: add a bio_submit_or_kill helper
Date: Tue, 7 Apr 2026 06:59:03 -0700 [thread overview]
Message-ID: <adUNpy-RlCD0eaMq@infradead.org> (raw)
In-Reply-To: <2b2998f6-260d-426d-9ea5-1019bdb8c77d@kernel.org>
On Mon, Apr 06, 2026 at 09:08:16AM +0200, Damien Le Moal wrote:
> > +{
> > + if ((flags & BLKDEV_ZERO_KILLABLE) && fatal_signal_pending(current)) {
> > + bio_await(bio, NULL, bio_endio_cb);
> > + return -EINTR;
>
> This was like this in the previous code, so not big deal, but should we perhaps
> return the bio error if there was one ? And return -EINTR if there was no error.
This only happens when the process was killed. In which case -EINTR as
a syscall return makes sense, independent of any previous error.
next prev parent reply other threads:[~2026-04-07 13:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-06 5:57 refactor submit_bio_wait and bio await helpers v2 Christoph Hellwig
2026-04-06 5:57 ` [PATCH 1/4] block: unify the synchronous bi_end_io callbacks Christoph Hellwig
2026-04-06 6:59 ` Damien Le Moal
2026-04-06 5:57 ` [PATCH 2/4] block: factor out a bio_await helper Christoph Hellwig
2026-04-06 7:05 ` Damien Le Moal
2026-04-06 5:57 ` [PATCH 3/4] block: add a bio_submit_or_kill helper Christoph Hellwig
2026-04-06 7:08 ` Damien Le Moal
2026-04-07 13:59 ` Christoph Hellwig [this message]
2026-04-06 5:57 ` [PATCH 4/4] xfs: use bio_await in xfs_zone_gc_reset_sync Christoph Hellwig
2026-04-06 7:09 ` Damien Le Moal
-- strict thread matches above, loose matches on Subject: below --
2026-04-01 14:03 refactor submit_bio_wait and bio await helpers Christoph Hellwig
2026-04-01 14:03 ` [PATCH 3/4] block: add a bio_submit_or_kill helper Christoph Hellwig
2026-04-01 15:42 ` Bart Van Assche
2026-04-06 5:51 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adUNpy-RlCD0eaMq@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=cem@kernel.org \
--cc=dlemoal@kernel.org \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox