From: Jens Axboe <axboe@kernel.dk>
To: Bart Van Assche <bvanassche@acm.org>,
Zhen Lei <thunder.leizhen@huawei.com>,
linux-block <linux-block@vger.kernel.org>
Cc: Damien Le Moal <damien.lemoal@wdc.com>
Subject: Re: [PATCH] block/mq-deadline: Speed up the dispatch of low-priority requests
Date: Thu, 26 Aug 2021 13:32:57 -0600 [thread overview]
Message-ID: <ae882282-7a15-5746-0c54-ff3f5435c022@kernel.dk> (raw)
In-Reply-To: <a1c76c24-5013-02b4-85f1-2d2896cca6dd@acm.org>
On 8/26/21 1:17 PM, Bart Van Assche wrote:
> On 8/26/21 11:45 AM, Jens Axboe wrote:
>> Bart, either we fix this up ASAP and get rid of the percpu counters in
>> the hot path, or we revert this patch.
>
> I'm at home taking care of my son because he is sick.
Take care of that, always more important than the kernel :-)
> Do you want to wait for Zhen to post a fixed version of his patch or do you
> want me to fix his patch?
To be a bit proactive, I queued up a revert. Messing with it at this
point is making me a bit nervous. If the final patch ends up looking
clean enough, then we can still go that route. But it really has to be
unequivocally done this late in the game...
--
Jens Axboe
next prev parent reply other threads:[~2021-08-26 19:33 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-26 14:40 [PATCH] block/mq-deadline: Speed up the dispatch of low-priority requests Zhen Lei
2021-08-26 18:09 ` Bart Van Assche
2021-08-26 18:13 ` Jens Axboe
2021-08-26 18:45 ` Jens Axboe
2021-08-26 19:17 ` Bart Van Assche
2021-08-26 19:32 ` Jens Axboe [this message]
2021-08-26 23:49 ` Bart Van Assche
2021-08-26 23:51 ` Jens Axboe
2021-08-27 0:03 ` Bart Van Assche
2021-08-27 0:05 ` Jens Axboe
2021-08-27 0:58 ` Bart Van Assche
2021-08-27 2:48 ` Bart Van Assche
2021-08-27 3:13 ` Jens Axboe
2021-08-27 4:49 ` Damien Le Moal
2021-08-27 14:34 ` Bart Van Assche
2021-08-29 23:02 ` Damien Le Moal
2021-08-30 2:31 ` Keith Busch
2021-08-30 3:03 ` Damien Le Moal
2021-08-30 2:40 ` Bart Van Assche
2021-08-30 3:07 ` Damien Le Moal
2021-08-30 17:14 ` Bart Van Assche
2021-08-30 21:42 ` Damien Le Moal
2021-08-28 1:45 ` Leizhen (ThunderTown)
2021-08-28 2:19 ` Bart Van Assche
2021-08-28 2:42 ` Leizhen (ThunderTown)
2021-08-28 13:14 ` Leizhen (ThunderTown)
2021-08-28 1:59 ` Leizhen (ThunderTown)
2021-08-28 2:41 ` Bart Van Assche
2021-08-27 2:30 ` Damien Le Moal
2021-08-28 2:14 ` Leizhen (ThunderTown)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae882282-7a15-5746-0c54-ff3f5435c022@kernel.dk \
--to=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=damien.lemoal@wdc.com \
--cc=linux-block@vger.kernel.org \
--cc=thunder.leizhen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox