From: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Yi Zhang <yi.zhang@redhat.com>
Subject: Re: [PATCH blktests 1/1] common/scsi_debug: use _patient_rmmod() to unload scsi_debug
Date: Thu, 16 Apr 2026 11:44:04 +0000 [thread overview]
Message-ID: <aeDLO7xKyOBkZpDu@shinmob> (raw)
In-Reply-To: <9a297b35-639c-417f-bf22-a20742a9adcd@acm.org>
On Apr 10, 2026 / 09:34, Bart Van Assche wrote:
> On 4/9/26 10:30 PM, Shin'ichiro Kawasaki wrote:
> > - modprobe -qr scsi_debug >&/dev/null
> > + _patient_rmmod scsi_debug >&/dev/null
>
> The output of none of the other _patient_rmmod calls is redirected to
> /dev/null. I propose to leave out the output redirection because of
> consistency.
Thanks, I completely agree with it. I folded in the suggested change and
applied the patch.
prev parent reply other threads:[~2026-04-16 11:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-10 5:30 [PATCH blktests 1/1] common/scsi_debug: use _patient_rmmod() to unload scsi_debug Shin'ichiro Kawasaki
2026-04-10 16:34 ` Bart Van Assche
2026-04-16 11:44 ` Shinichiro Kawasaki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeDLO7xKyOBkZpDu@shinmob \
--to=shinichiro.kawasaki@wdc.com \
--cc=bvanassche@acm.org \
--cc=linux-block@vger.kernel.org \
--cc=yi.zhang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox