From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39D9B146A96 for ; Fri, 14 Jun 2024 16:04:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718381073; cv=none; b=JodinkZXsfmUB5VXEbptmnJu6hYJBVy1F2Vw61RHFjr1GB78XIsvP/C7d8KQjzQAHqCwuhB3D9tSWdmeLDW1A3xkI4yLBQ+HQjlKi08cVfPEDy6QcKY0F1GEOMtnl9PrZLNqBf5n1NQG+Eaa5WN3ZAikHx87jWIyR4G8Tn0GJ2g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718381073; c=relaxed/simple; bh=9K03K1EOb8N+Ye1xk9pBTeEFKwI2LrZ11+DIvfyUMMw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=b2j+Fe7if0AATIX1mXBlIVRhlZWVuPQ3aw9xZs7Ol2DPuMv1Iy9Oji/rygrSrrKMidZpFpShCHG2y0ovThC2LPef12WIkcAeAjPuq6ekJ4YfGZxC4JlfQrsto6ebTdtjnmGNuvVw3R7ICpeJ1+EIiSnD3RsO/w6y6VykOw/DovA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=FaQFEUyn; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="FaQFEUyn" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-64ecc2f111dso216445a12.2 for ; Fri, 14 Jun 2024 09:04:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1718381071; x=1718985871; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hCV+IWPk0IvkJKtq2bRF2qxH9qFCYf5hnPfztISGB5o=; b=FaQFEUynhkHMl9J/rAt4Z4QUQgbrc7UVEbBDgAhsJ6FkxZhgjmTBnjktvoPg/oE4AV CRgb6oqD/4TglpnMU8QyeZSzco3USa9DR+I/d5BJgRh+Gtw8O2F2iIhksc9yGlFj5VOc oGgqeb7X5gPmTnoxBzXbJkFo7sB4e/HZAZw3pqpWzr+oPEk1BWGxBxET7PveqWFuhgaN CR1LEiUZViJ/V/k8rlI5I88iWpBKQH5ezUGHTmXuAR8TpT9Ugws7DQH4C1ofuNxjc+Bl 5KWjr3H4fvP/OzpQ45OEmMzT9hpkm5Ys0MbuGixhsLKqDaEvLN3Jywn/YAI4X3Fkqt0L mDZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718381071; x=1718985871; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hCV+IWPk0IvkJKtq2bRF2qxH9qFCYf5hnPfztISGB5o=; b=cWb8WtO25Car41O4EmsN57x7uhSNp88LtYteJM6UpoPLd+IHK7JpEIM61H7TbxBsiy IXOY7rPU4JkY3spbeFBEFHMYk9WCYNQKgKovF8BOcdcJ4nJpMPn6XsRc8gmyDpaCpg8O B2+vsCW5UJ1YSqqnws/3rk1UhCg+ZXcRgw+jB/Cg7gjygjWEj/k8lrx2psE/mIKjEbKW IE5j43iD7Mw20E2nJuRNzDVleRXPYJg8VlS/GUAn4LmkS0gc1ajTUr9bbWf04m9LMZsX jVh7C5W7yM+CdDvmuvAyg7IRXMGO+Xz6n/9AB8xiqGTe6XkPeq58hor/MTpvXY+tDT7G deOw== X-Forwarded-Encrypted: i=1; AJvYcCVMhBMcDAgQl5D+UcNQokkzCOIJHUkM0W0zLo3Ui5voZRKqWAzu4e8gXFEegpxJwgswdm9gNftahQ1HEKRqUPHKBUZln4fVHrIHy4c= X-Gm-Message-State: AOJu0Yy61rkRwYNWe6JAWu1pv1e0U1ybozBdFz7PVS5h+TYH/bvNlv/I xKJtSJwXrjg6BDOJrDRuWZHm73WrzBml3DCEsk5EUBYmm0HeU8C4jV1R+i00RI8= X-Google-Smtp-Source: AGHT+IFcef25ONKjtc899Mq79qjBziTk8bpO5RUNlOaMS9rx17DLdtap7aVVIksBs4B1DV1O5X5XIA== X-Received: by 2002:aa7:80d7:0:b0:705:daf0:9004 with SMTP id d2e1a72fcca58-705daf091c8mr2211921b3a.3.1718381071337; Fri, 14 Jun 2024 09:04:31 -0700 (PDT) Received: from [192.168.1.150] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-705ccb8d9acsm3207006b3a.197.2024.06.14.09.04.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Jun 2024 09:04:30 -0700 (PDT) Message-ID: Date: Fri, 14 Jun 2024 10:04:28 -0600 Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: move integrity settings to queue_limits v3 To: Christoph Hellwig Cc: "Martin K. Petersen" , Mike Snitzer , Mikulas Patocka , Song Liu , Yu Kuai , Dan Williams , Vishal Verma , Dave Jiang , Ira Weiny , Keith Busch , Sagi Grimberg , Chaitanya Kulkarni , linux-block@vger.kernel.org, dm-devel@lists.linux.dev, linux-raid@vger.kernel.org, nvdimm@lists.linux.dev, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org References: <20240613084839.1044015-1-hch@lst.de> <20240614160322.GA16649@lst.de> Content-Language: en-US From: Jens Axboe In-Reply-To: <20240614160322.GA16649@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/14/24 10:03 AM, Christoph Hellwig wrote: > On Fri, Jun 14, 2024 at 06:33:41AM -0600, Jens Axboe wrote: >>> The series is based on top of my previously sent "convert the SCSI ULDs >>> to the atomic queue limits API v2" API. >> >> I was going to queue this up, but: >> >> drivers/scsi/sd.c: In function ?sd_revalidate_disk?: >> drivers/scsi/sd.c:3658:45: error: ?lim? undeclared (first use in this function) >> 3658 | sd_config_protection(sdkp, &lim); >> | ^~~ >> drivers/scsi/sd.c:3658:45: note: each undeclared identifier is reported only once for each function it appears in > > That sounds like you didn't apply the above mentioned > "convert the SCSI ULDs to the atomic queue limits API v2" series before? That might indeed explain it... Surprising it applied without. -- Jens Axboe