From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D3CAEB64D9 for ; Thu, 15 Jun 2023 08:25:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232816AbjFOIYs (ORCPT ); Thu, 15 Jun 2023 04:24:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229510AbjFOIYs (ORCPT ); Thu, 15 Jun 2023 04:24:48 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D1681A3; Thu, 15 Jun 2023 01:24:47 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id CFDF61FDDA; Thu, 15 Jun 2023 08:24:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1686817485; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o4kh08IxP4hlN+Q2BPPxchV5kMlwNPXBnjg2rvqUSwg=; b=WD2hdqzIU+H0hC/qc9xqVsgAinm56C3JO83Qe54DMOlb3jOFbBOGBCRol7tEHWQDtrTKrx aEdJ849lXQJHwlBI1YuOcWjhmiCbf2GZc2dx2hmhXmzCvqg+KDFBs3XailNMcSw+kp7BnN tRaF+QzcY1MWkfvQCcx4J7qGVp9Y9fA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1686817485; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o4kh08IxP4hlN+Q2BPPxchV5kMlwNPXBnjg2rvqUSwg=; b=CyU8+nfeZGtU20nI4wMPp46Ir0irABJt9igwvRGEq+YZ+/uT8c3P4vs+yZyYEL0oUSI82v hXved1TD8Az6LQDA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C1D6013467; Thu, 15 Jun 2023 08:24:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id O+sXL83KimTwLgAAMHmgww (envelope-from ); Thu, 15 Jun 2023 08:24:45 +0000 Message-ID: Date: Thu, 15 Jun 2023 10:24:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 07/11] md-bitmap: cleanup read_sb_page To: Christoph Hellwig , Song Liu Cc: linux-raid@vger.kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org References: <20230615064840.629492-1-hch@lst.de> <20230615064840.629492-8-hch@lst.de> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <20230615064840.629492-8-hch@lst.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 6/15/23 08:48, Christoph Hellwig wrote: > Convert read_sb_page to the normal kernel coding style, calculate the > target sector only once, and add a local iosize variable to make the call > to sync_page_io more readable. > > Signed-off-by: Christoph Hellwig > --- > drivers/md/md-bitmap.c | 23 +++++++++++------------ > 1 file changed, 11 insertions(+), 12 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes