public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Phillip Potter <phil@philpotter.co.uk>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, daan@amutable.com
Subject: Re: [PATCH 1/1] cdrom, scsi: sr: propagate read-only status to block layer via set_disk_ro()
Date: Wed, 29 Apr 2026 20:53:38 +0100	[thread overview]
Message-ID: <afJhwgTJF-Kqz93h@equinox> (raw)
In-Reply-To: <8816ec1a-a4cb-4c68-a99a-79e9d59cc288@kernel.dk>

On Mon, Apr 27, 2026 at 03:52:12PM -0600, Jens Axboe wrote:
> On 4/27/26 3:01 PM, Phillip Potter wrote:
> > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> > Signed-off-by: Daan De Meyer <daan@amutable.com>
> > Link: https://lore.kernel.org/all/20260422113206.246267-1-daan@amutable.com
> > Reviewed-by: Phillip Potter <phil@philpotter.co.uk>
> > Link: https://lore.kernel.org/all/ae59luYMh6npxD09@equinox
> > Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
> > Link: https://lore.kernel.org/all/yq1jytti447.fsf@ca-mkp.ca.oracle.com
> > Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
> 
> A few notes:
> 
> - Please don't include a ton of Link tags in the commit message. Don't
>   add anything unless it's a link to a bug report, and your patch fixes
>   that bug.
> 
> - Signed-off-by implies Reviewed-by, you don't need both of those.
> 
> -- 
> Jens Axboe

Sorry about that, didn't realise it was bad as I've done it that way
previously without issue. Will make sure not to do it again :-)

Thanks for taking Daan's patch.

Regards,
Phil

  reply	other threads:[~2026-04-29 19:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-27 21:01 [PATCH 0/1] cdrom, sr: patch for inclusion Phillip Potter
2026-04-27 21:01 ` [PATCH 1/1] cdrom, scsi: sr: propagate read-only status to block layer via set_disk_ro() Phillip Potter
2026-04-27 21:52   ` Jens Axboe
2026-04-29 19:53     ` Phillip Potter [this message]
2026-04-27 21:52 ` [PATCH 0/1] cdrom, sr: patch for inclusion Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=afJhwgTJF-Kqz93h@equinox \
    --to=phil@philpotter.co.uk \
    --cc=axboe@kernel.dk \
    --cc=daan@amutable.com \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox