From: Christoph Hellwig <hch@infradead.org>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Marco Elver <elver@google.com>
Subject: Re: [PATCH 15/27] loop: Split loop_change_fd()
Date: Tue, 9 Jun 2026 22:30:40 -0700 [thread overview]
Message-ID: <aij2gBmDwQl7AxTl@infradead.org> (raw)
In-Reply-To: <f835863049bc0364d80c69a7eeb9514e2a698ae2.1781042470.git.bvanassche@acm.org>
On Tue, Jun 09, 2026 at 03:05:02PM -0700, Bart Van Assche wrote:
> Prepare for adding a second call of __loop_change_fd().
A bit confusing message. Yes, you latter add another call, but it's
from the same caller to sort out the locking mess, and that is directly
relevant to the scope of the factored out helper. So please state
that. Same for the next patch. All in merging the first free loop
patches would probably be easier to follow.
next prev parent reply other threads:[~2026-06-10 5:30 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-09 22:04 [PATCH 00/27] Enable lock context analysis in drivers/block/ Bart Van Assche
2026-06-09 22:04 ` [PATCH 01/27] aoe: Enable lock context analysis Bart Van Assche
2026-06-09 22:04 ` [PATCH 02/27] drbd: Remove "extern" from function declarations Bart Van Assche
2026-06-10 5:17 ` Christoph Hellwig
2026-06-09 22:04 ` [PATCH 03/27] drbd: Retain one _get_ldev_if_state() implementation Bart Van Assche
2026-06-10 5:18 ` Christoph Hellwig
2026-06-09 22:04 ` [PATCH 04/27] drbd: Remove the get_ldev_if_state() macro Bart Van Assche
2026-06-10 5:19 ` Christoph Hellwig
2026-06-09 22:04 ` [PATCH 05/27] drbd: Remove the 'local' lock context Bart Van Assche
2026-06-10 5:19 ` Christoph Hellwig
2026-06-09 22:04 ` [PATCH 06/27] drbd: Simplify the bitmap locking functions Bart Van Assche
2026-06-10 5:20 ` Christoph Hellwig
2026-06-09 22:04 ` [PATCH 07/27] drbd: Move two declarations Bart Van Assche
2026-06-10 5:20 ` Christoph Hellwig
2026-06-09 22:04 ` [PATCH 08/27] drbd: Pass 'resource' directly to complete_conflicting_writes() Bart Van Assche
2026-06-10 5:21 ` Christoph Hellwig
2026-06-09 22:04 ` [PATCH 09/27] drbd: Split drbd_nl_get_connections_dumpit() Bart Van Assche
2026-06-10 5:22 ` Christoph Hellwig
2026-06-09 22:04 ` [PATCH 10/27] drbd: Make a mutex_unlock() call unconditional Bart Van Assche
2026-06-10 5:22 ` Christoph Hellwig
2026-06-09 22:04 ` [PATCH 11/27] drbd: Split drbd_req_state() Bart Van Assche
2026-06-10 5:24 ` Christoph Hellwig
2026-06-09 22:04 ` [PATCH 12/27] drbd: Convert drbd_req_state() to unconditional locking Bart Van Assche
2026-06-10 5:25 ` Christoph Hellwig
2026-06-09 22:05 ` [PATCH 13/27] drbd: Annotate drbd_bm_{lock,unlock}() Bart Van Assche
2026-06-10 5:26 ` Christoph Hellwig
2026-06-09 22:05 ` [PATCH 14/27] drbd: Enable lock context analysis Bart Van Assche
2026-06-09 22:05 ` [PATCH 15/27] loop: Split loop_change_fd() Bart Van Assche
2026-06-10 5:30 ` Christoph Hellwig [this message]
2026-06-09 22:05 ` [PATCH 16/27] loop: Split loop_configure() Bart Van Assche
2026-06-09 22:05 ` [PATCH 17/27] loop: Remove the "bool global" function argument Bart Van Assche
2026-06-09 22:05 ` [PATCH 18/27] loop: Add lock context annotations Bart Van Assche
2026-06-10 9:21 ` Nilay Shroff
2026-06-09 22:05 ` [PATCH 19/27] mtip32: Enable lock context analysis Bart Van Assche
2026-06-09 22:05 ` [PATCH 20/27] nbd: " Bart Van Assche
2026-06-10 8:02 ` Nilay Shroff
2026-06-09 22:05 ` [PATCH 21/27] null_blk: " Bart Van Assche
2026-06-09 23:42 ` Damien Le Moal
2026-06-10 5:31 ` Christoph Hellwig
2026-06-10 7:28 ` Nilay Shroff
2026-06-09 22:05 ` [PATCH 22/27] rbd: " Bart Van Assche
2026-06-10 5:32 ` Christoph Hellwig
2026-06-09 22:05 ` [PATCH 23/27] ublk: " Bart Van Assche
2026-06-10 2:24 ` Ming Lei
2026-06-09 22:05 ` [PATCH 24/27] xen-blkback: " Bart Van Assche
2026-06-09 22:05 ` [PATCH 25/27] zram: " Bart Van Assche
2026-06-09 22:05 ` [PATCH 26/27] rnbd: " Bart Van Assche
2026-06-09 22:05 ` [PATCH 27/27] block: Enable lock context analysis for all block drivers Bart Van Assche
2026-06-10 5:34 ` [PATCH 00/27] Enable lock context analysis in drivers/block/ Christoph Hellwig
2026-06-10 7:31 ` Marco Elver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aij2gBmDwQl7AxTl@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=elver@google.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox