From: Keith Busch <kbusch@kernel.org>
To: "Dr. David Alan Gilbert" <linux@treblig.org>
Cc: linux-block@vger.kernel.org, dm-devel@lists.linux.dev
Subject: Re: Repeatable, raid1+O_DIRECT, hang/warn
Date: Mon, 15 Jun 2026 13:25:17 -0600 [thread overview]
Message-ID: <ajBRnUqXd7DqxLiG@kbusch-mbp> (raw)
In-Reply-To: <ajA5kpUraXqh9ag9@gallifrey>
On Mon, Jun 15, 2026 at 05:42:42PM +0000, Dr. David Alan Gilbert wrote:
> * Keith Busch (kbusch@kernel.org) wrote:
> > On Mon, Jun 15, 2026 at 04:37:39PM +0000, Dr. David Alan Gilbert wrote:
> > > Hi Keith,
> > > Thanks for the patch, alas it doesn't seem to be helping here;
> > > the first warn is still the same
> > > and it still hangs the test process hard and eventually BUGs at
> > >
> > > void blk_mq_end_request(struct request *rq, blk_status_t error)
> > > {
> > > if (blk_update_request(rq, error, blk_rq_bytes(rq)))
> > > BUG();
> >
> > Oh, that was not expected.
> >
> > What is the dma alignment requirement of your backing devices? You can
> > find the attribute for sda at /sys/block/sda/queue/dma_alignment. I'm
> > expecting 511, but just want to double check.
>
> Yeh looks like it:
> /sys/block/sda/queue/dma_alignment:511
> /sys/block/sdb/queue/dma_alignment:511
>
> all of the lvm also looks like it is.
Thanks for confirming.
I'm struggling to see how you're getting there with your reproducer with
the proposal included. I can see other short comings with preadv or
really large pread's, but not with a 4k pread. For those other issues
this patch can fix it:
https://lore.kernel.org/linux-block/20260612223205.465913-1-kbusch@meta.com/
It is currently staged for upstream, so hasn't landed yet. But again, I
don't think those conditions apply to what you're seeing, but worth a
shot on top of the previous proposal to use byte units instead of
sectors.
In the meantime, since I so far can't reproduce this after including my
previous proposal, I may have to request trying out a debug patch to get
some more visibility on what's happening if that's okay.
next prev parent reply other threads:[~2026-06-15 19:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-14 17:57 Repeatable, raid1+O_DIRECT, hang/warn Dr. David Alan Gilbert
2026-06-15 10:34 ` Thorsten Leemhuis
2026-06-15 12:50 ` Dr. David Alan Gilbert
2026-06-15 23:16 ` Vjaceslavs Klimovs
2026-06-16 0:06 ` Keith Busch
2026-06-16 1:25 ` Vjaceslavs Klimovs
2026-06-16 12:57 ` Dr. David Alan Gilbert
2026-06-16 13:08 ` Dr. David Alan Gilbert
2026-06-16 14:04 ` Dr. David Alan Gilbert
2026-06-16 14:19 ` Keith Busch
2026-06-16 15:55 ` Dr. David Alan Gilbert
2026-06-16 15:55 ` Mikulas Patocka
2026-06-16 16:05 ` Keith Busch
2026-06-15 13:07 ` Zdenek Kabelac
2026-06-15 13:20 ` Dr. David Alan Gilbert
2026-06-15 15:20 ` Keith Busch
2026-06-15 15:35 ` Keith Busch
2026-06-15 16:37 ` Dr. David Alan Gilbert
2026-06-15 17:19 ` Keith Busch
2026-06-15 17:42 ` Dr. David Alan Gilbert
2026-06-15 19:25 ` Keith Busch [this message]
2026-06-15 20:09 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ajBRnUqXd7DqxLiG@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=dm-devel@lists.linux.dev \
--cc=linux-block@vger.kernel.org \
--cc=linux@treblig.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox