Linux block layer
 help / color / mirror / Atom feed
From: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To: Sebastian Chlad <sebastianchlad@gmail.com>
Cc: linux-block@vger.kernel.org,
	 Sebastian Chlad <sebastian.chlad@suse.com>,
	alan.adamson@oracle.com
Subject: Re: [PATCH blktests] scsi/009: fix unset bytes_to_write in TEST 8
Date: Wed, 17 Jun 2026 13:29:13 +0900	[thread overview]
Message-ID: <ajIhtkOIMXeM6BAI@shinmob> (raw)
In-Reply-To: <20260614181651.11554-2-sebastian.chlad@suse.com>

CC+ Alan,

On Jun 14, 2026 / 20:16, Sebastian Chlad wrote:
> bytes_to_write was never assigned before TEST 8, causing it to pass for
> the wrong reason. Set it to atomic_unit_max_bytes + logical_block_size
> and update the golden output with the expected "pwrite: Invalid argument"
> from xfs_io.
> 
> Signed-off-by: Sebastian Chlad <sebastian.chlad@suse.com>

Thanks. The change looks good to me.

I will wait a few more days just in case anyone has opinion on the change.
FYI: Sebastian posted a similar change for nvme/059 [*].

[*] https://github.com/linux-blktests/blktests/pull/245

      reply	other threads:[~2026-06-17  4:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-14 18:16 [PATCH blktests] scsi/009: fix unset bytes_to_write in TEST 8 Sebastian Chlad
2026-06-17  4:29 ` Shin'ichiro Kawasaki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ajIhtkOIMXeM6BAI@shinmob \
    --to=shinichiro.kawasaki@wdc.com \
    --cc=alan.adamson@oracle.com \
    --cc=linux-block@vger.kernel.org \
    --cc=sebastian.chlad@suse.com \
    --cc=sebastianchlad@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox