From: Tejun Heo <tj@kernel.org>
To: Yousef Alhouseen <alhouseenyousef@gmail.com>
Cc: josef@toxicpanda.com, axboe@kernel.dk, cgroups@vger.kernel.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools/cgroup: iocost_monitor: parse help before importing drgn
Date: Wed, 24 Jun 2026 08:59:40 -1000 [thread overview]
Message-ID: <ajwpHLIrr2uEOoAE@slm.duckdns.org> (raw)
In-Reply-To: <20260624123652.8108-1-alhouseenyousef@gmail.com>
On Wed, Jun 24, 2026 at 02:36:52PM +0200, Yousef Alhouseen wrote:
> iocost_monitor.py imports drgn before argparse can handle "-h" or report
> argument errors. That makes basic usage help fail on systems where drgn is
> not installed.
>
> Parse arguments before importing drgn so the help and argument-error paths
> work without the runtime debugging dependency. Normal execution still
> imports drgn before reading kernel state.
>
> Signed-off-by: Yousef Alhouseen <alhouseenyousef@gmail.com>
Applied to cgroup/for-7.3.
Thanks.
--
tejun
prev parent reply other threads:[~2026-06-24 18:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-24 12:36 [PATCH] tools/cgroup: iocost_monitor: parse help before importing drgn Yousef Alhouseen
2026-06-24 18:59 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ajwpHLIrr2uEOoAE@slm.duckdns.org \
--to=tj@kernel.org \
--cc=alhouseenyousef@gmail.com \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox