From: Keith Busch <kbusch@kernel.org>
To: Mike Snitzer <snitzer@kernel.org>
Cc: axboe@kernel.dk, Mikulas Patocka <mpatocka@redhat.com>,
Benjamin Marzinski <bmarzins@redhat.com>,
Keith Busch <kbusch@meta.com>,
dm-devel@lists.linux.dev, linux-block@vger.kernel.org,
"Dr. David Alan Gilbert" <linux@treblig.org>,
Vjaceslavs Klimovs <vklimovs@gmail.com>
Subject: Re: [PATCH 2/2] dm-raid1: don't fail the mirror for invalid I/O errors
Date: Wed, 8 Jul 2026 11:57:30 -0600 [thread overview]
Message-ID: <ak6Pire-LnJeHMHa@kbusch-mbp> (raw)
In-Reply-To: <ak1XNlyFC34W47iP@kernel.org>
On Tue, Jul 07, 2026 at 03:44:54PM -0400, Mike Snitzer wrote:
> So where does dm-raid1 and dm-crypt stand relative to these DIO memory
> alignment changes? Inferring they are pretty exposed.
dm-raid1 currently has a gap in handling badly behaved direct-io
applications. Worst case it may return success to a failed write command
that used to return an appropriate error before, so a silent corruption.
On reads, it can cause the array to be considered degraded when there's
nothing wrong with it.
There's no errors with dm-crypt today that I know of. I just want to
make it to be more aligned to the backing hardware.
next prev parent reply other threads:[~2026-07-08 17:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-16 15:05 [PATCH 1/2] dm-io: clone the source bio instead of copying its biovec Keith Busch
2026-06-16 15:05 ` [PATCH 2/2] dm-raid1: don't fail the mirror for invalid I/O errors Keith Busch
2026-06-16 17:54 ` Dr. David Alan Gilbert
2026-06-16 18:48 ` Keith Busch
2026-06-16 20:09 ` Dr. David Alan Gilbert
2026-06-16 23:45 ` Keith Busch
2026-06-16 23:47 ` Dr. David Alan Gilbert
2026-06-17 15:08 ` Keith Busch
2026-06-17 15:33 ` Dr. David Alan Gilbert
2026-06-17 16:21 ` Keith Busch
2026-06-17 16:44 ` Dr. David Alan Gilbert
2026-06-17 16:54 ` Keith Busch
2026-06-17 16:59 ` Dr. David Alan Gilbert
2026-06-19 2:07 ` Vjaceslavs Klimovs
2026-06-16 15:40 ` Keith Busch
2026-06-16 15:58 ` Keith Busch
2026-06-24 11:14 ` Mikulas Patocka
2026-07-06 20:52 ` Keith Busch
2026-07-07 19:44 ` Mike Snitzer
2026-07-08 17:57 ` Keith Busch [this message]
2026-07-08 23:24 ` Benjamin Marzinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ak6Pire-LnJeHMHa@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=bmarzins@redhat.com \
--cc=dm-devel@lists.linux.dev \
--cc=kbusch@meta.com \
--cc=linux-block@vger.kernel.org \
--cc=linux@treblig.org \
--cc=mpatocka@redhat.com \
--cc=snitzer@kernel.org \
--cc=vklimovs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox