From: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH blktests] Fix _get_page_size()
Date: Mon, 6 Jul 2026 11:55:15 +0900 [thread overview]
Message-ID: <aksY0-MFextyvx6n@shinmob> (raw)
In-Reply-To: <x497bnvlxlc.fsf@segfault.usersys.redhat.com>
On Jun 18, 2026 / 10:41, Jeff Moyer wrote:
> There is no CONFIG_PAGE_SHIFT stored in /boot/config-`uname -r` on RHEL
> systems (maybe all systems?). As a result, tests that make use of
> _get_page_size() were doing the wrong thing. For example, throtl/002
> used it to calculate I/O sizes for direct IO. Those sizes ended up not
> being a multiple of the logical block size, and hence throtl/002 was
> failing.
>
> Fixes: 8eca9fa ("common/rc, scsi/011, zbd/010: introduce _page_size_equals() helper")
> Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
FYI, I applied the patch together with the other patch to require the getconf
command. Thanks!
prev parent reply other threads:[~2026-07-06 2:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-18 14:41 [PATCH blktests] Fix _get_page_size() Jeff Moyer
2026-06-20 1:26 ` Shin'ichiro Kawasaki
2026-06-20 3:55 ` Bart Van Assche
2026-06-20 4:51 ` Shin'ichiro Kawasaki
2026-06-20 7:11 ` Bart Van Assche
2026-06-22 11:38 ` Shin'ichiro Kawasaki
2026-06-22 17:31 ` Omar Sandoval
2026-06-22 22:27 ` Shin'ichiro Kawasaki
2026-07-06 2:55 ` Shin'ichiro Kawasaki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aksY0-MFextyvx6n@shinmob \
--to=shinichiro.kawasaki@wdc.com \
--cc=jmoyer@redhat.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox