From: Keith Busch <kbusch@kernel.org>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Jan Kara <jack@suse.cz>, Christoph Hellwig <hch@lst.de>,
Keith Busch <kbusch@meta.com>,
linux-block@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org,
axboe@kernel.dk, brauner@kernel.org, cem@kernel.org,
jaegeuk@kernel.org, aalbersh@kernel.org, tytso@mit.edu
Subject: Re: [PATCH] fs: report direct io constraints through file_getattr
Date: Fri, 10 Jul 2026 17:11:23 -0600 [thread overview]
Message-ID: <alF8G6Fw2aFh-2_o@kbusch-mbp> (raw)
In-Reply-To: <20260710212058.GA1911@quark>
On Fri, Jul 10, 2026 at 05:20:58PM -0400, Eric Biggers wrote:
> So far I haven't seen the point. Yes, applications can benefit from the
> lower alignment in theory. But especially with encryption/decryption,
> it isn't at all easy to support. This has apparently been getting
> learned the hard way, as (for example) alignment was initially relaxed
> for dm-crypt without testing it, and it had to be reverted
> (https://lore.kernel.org/dm-devel/20221103152559.1909328-1-kbusch@meta.com/).
To be fair, that was most certainly tested in production, and it was
reverted for a bug not related to alignment. It was just a mishandled
early exit corner case accessing uninitialized fields; a trivial fixup.
next prev parent reply other threads:[~2026-07-10 23:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260708011843.1036846-1-kbusch@meta.com>
2026-07-09 7:13 ` [PATCH] fs: report direct io constraints through file_getattr Christoph Hellwig
2026-07-09 8:51 ` Andrey Albershteyn
2026-07-10 21:28 ` [f2fs-dev] " Eric Biggers
2026-07-09 9:14 ` Jan Kara
2026-07-10 21:20 ` Eric Biggers
2026-07-10 23:11 ` Keith Busch [this message]
2026-07-09 13:46 ` Keith Busch
2026-07-10 4:35 ` Christoph Hellwig
2026-07-10 15:22 ` Keith Busch
2026-07-10 21:25 ` [f2fs-dev] " Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alF8G6Fw2aFh-2_o@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=aalbersh@kernel.org \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=cem@kernel.org \
--cc=ebiggers@kernel.org \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=jaegeuk@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox