From: Keith Busch <kbusch@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, Al Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Qu Wenruo <wqu@suse.com>, Neptune <z1281552865@gmail.com>,
linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 3/3] block,iov_iter: move bio_iov_iter_align_down into iov_iter_extract_bvecs
Date: Wed, 15 Jul 2026 09:00:15 -0600 [thread overview]
Message-ID: <alegfwkrEpy75dAZ@kbusch-mbp> (raw)
In-Reply-To: <20260715043417.GA15746@lst.de>
On Wed, Jul 15, 2026 at 06:34:17AM +0200, Christoph Hellwig wrote:
> On Tue, Jul 14, 2026 at 10:44:56AM -0600, Keith Busch wrote:
> > On Tue, Jul 14, 2026 at 04:50:26PM +0200, Christoph Hellwig wrote:
> > > Yeah, we need to support that. Kinda interesting that xfstests did
> > > not hit it, though. So back to the previous version.
> >
> > Here's a simple test for this case if you want to try. This should work
> > for any file or raw disk with nvme backing storage.
> >
> > It prints "Success" before this series, and "Bad Address" after.
>
> Yes, assuming the NVMe doesn't support SGLs and has a 512 byte
The same test should be applicable to 4k LBS and SGL capable too!
> block size.. I guess this is going into blktessts/xfstests
> once the query API lands?
It's a simplfied version of this one:
https://github.com/linux-blktests/blktests/blob/master/src/dio-offsets.c#L269
Though that is incorrectly expecting failure since older kernels didn't
support sub-sector io vectors. If only we exported the necessary
attributes to tell user space what's allowed... :)
prev parent reply other threads:[~2026-07-15 15:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 13:11 bio bounce buffering fixes Christoph Hellwig
2026-07-14 13:11 ` [PATCH 1/3] block: handle huge zero folios in bio_free_folios Christoph Hellwig
2026-07-14 13:11 ` [PATCH 2/3] block: simplify minsize alignment in bio_iov_iter_bounce_write Christoph Hellwig
2026-07-14 13:12 ` [PATCH 3/3] block,iov_iter: move bio_iov_iter_align_down into iov_iter_extract_bvecs Christoph Hellwig
2026-07-14 14:26 ` Keith Busch
2026-07-14 14:50 ` Christoph Hellwig
2026-07-14 16:44 ` Keith Busch
2026-07-15 4:34 ` Christoph Hellwig
2026-07-15 15:00 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alegfwkrEpy75dAZ@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=wqu@suse.com \
--cc=z1281552865@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox