From: Christoph Hellwig <hch@infradead.org>
To: Jackie Liu <liu.yun@linux.dev>
Cc: xboe@kernel.dk, linux-block@vger.kernel.org
Subject: Re: [PATCH] block: show operation in error injection rules
Date: Thu, 16 Jul 2026 02:20:40 -0700 [thread overview]
Message-ID: <aliiaJIvu4MXzAHX@infradead.org> (raw)
In-Reply-To: <20260715073341.95129-1-liu.yun@linux.dev>
On Wed, Jul 15, 2026 at 03:33:41PM +0800, Jackie Liu wrote:
> From: Jackie Liu <liuyun01@kylinos.cn>
>
> Rules listed through the error_injection debugfs file omit the block
> operation they match. As a result, rules that differ only in operation
> are indistinguishable even though op is mandatory when adding a rule.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2026-07-16 9:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-15 7:33 [PATCH] block: show operation in error injection rules Jackie Liu
2026-07-16 9:20 ` Christoph Hellwig [this message]
2026-07-16 12:12 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aliiaJIvu4MXzAHX@infradead.org \
--to=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=liu.yun@linux.dev \
--cc=xboe@kernel.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox