From: Christoph Hellwig <hch@infradead.org>
To: Qu Wenruo <wqu@suse.com>,
Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>,
Brendan Jackman <jackmanb@google.com>,
Johannes Weiner <hannes@cmpxchg.org>, Zi Yan <ziy@nvidia.com>
Cc: linux-btrfs@vger.kernel.org, linux-block@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH] block: do not warn when doing greedy allocation in folio_alloc_greedy()
Date: Thu, 16 Jul 2026 02:29:50 -0700 [thread overview]
Message-ID: <alikjtke-YNWdd1I@infradead.org> (raw)
In-Reply-To: <d10571445ee505d95ba6eaad7558fc1f556d2921.1784020005.git.wqu@suse.com>
On Tue, Jul 14, 2026 at 06:37:39PM +0930, Qu Wenruo wrote:
> while (*size > minsize) {
> - folio = folio_alloc(gfp | __GFP_NORETRY, get_order(*size));
> + folio = folio_alloc(gfp | __GFP_NORETRY | __GFP_NOWARN,
> + get_order(*size));
I though I read somewhere that we now don't have to specify
__GFP_NOWARN when using __GFP_NORETRY, but a quick dive into the page
allocator suggest that no such thing exists.
But can we make it happen? Having to specify __GFP_NOWARN when the
caller clearly indicated that failure is perfectly fine using
__GFP_NORETRY is silly. The same probably applies to
__GFP_RETRY_MAYFAIL.
next prev parent reply other threads:[~2026-07-16 9:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 9:07 [PATCH] block: do not warn when doing greedy allocation in folio_alloc_greedy() Qu Wenruo
2026-07-15 22:34 ` Jens Axboe
2026-07-16 9:29 ` Christoph Hellwig [this message]
2026-07-16 10:05 ` Vlastimil Babka (SUSE)
2026-07-16 10:33 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alikjtke-YNWdd1I@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=jackmanb@google.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=wqu@suse.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox