Linux block layer
 help / color / mirror / Atom feed
From: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To: Sebastian Chlad <sebastianchlad@gmail.com>
Cc: linux-block@vger.kernel.org,  Sebastian Chlad <sebastian.chlad@suse.com>
Subject: Re: [PATCH blktests 1/2] loop/009: only skip on a genuinely unrecognized --ping option
Date: Fri, 24 Jul 2026 09:46:12 +0900	[thread overview]
Message-ID: <amK1dRmJSiaLbPvu@shinhome> (raw)
In-Reply-To: <20260721160432.27409-1-sebastian.chlad@suse.com>

On Jul 21, 2026 / 18:04, Sebastian Chlad wrote:
> udevadm control --ping can also fail when udevd is busy or unresponsive
> not only when the option is genuinely unsupported. Treating any failure
> as "unsupported" risked masking a real udevd problem behind a
> misleading skip reason instead of letting the test run and report it.
> 
> Signed-off-by: Sebastian Chlad <sebastian.chlad@suse.com>
> ---
>  tests/loop/009 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/loop/009 b/tests/loop/009
> index d3c7991..944f53b 100755
> --- a/tests/loop/009
> +++ b/tests/loop/009
> @@ -11,7 +11,7 @@ DESCRIPTION="check that LOOP_CONFIGURE sends uevents for partitions"
>  QUICK=1
>  
>  requires() {
> -	if ! udevadm control --ping >& /dev/null; then
> +	if ! udevadm control --help 2>&1 | grep -q -- '--ping'; then

I applied this patch. FYI, I took the liberty to replace the short option -q
above with the long option --quiet. Thanks!

      parent reply	other threads:[~2026-07-24  0:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-21 16:04 [PATCH blktests 1/2] loop/009: only skip on a genuinely unrecognized --ping option Sebastian Chlad
2026-07-21 16:04 ` [PATCH blktests 2/2] loop/006: settle udev before completing the test Sebastian Chlad
2026-07-24  0:46   ` Shin'ichiro Kawasaki
2026-07-24  0:46 ` Shin'ichiro Kawasaki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=amK1dRmJSiaLbPvu@shinhome \
    --to=shinichiro.kawasaki@wdc.com \
    --cc=linux-block@vger.kernel.org \
    --cc=sebastian.chlad@suse.com \
    --cc=sebastianchlad@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox