From: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] zloop: zero out only the unread tail of short reads
Date: Thu, 30 Jul 2026 16:27:36 +0900 [thread overview]
Message-ID: <amr8tz3Bgh5lQr3H@shinmob> (raw)
In-Reply-To: <4f18395a-7ff1-4a9a-8aef-4790d0cd8944@kernel.org>
On Jul 30, 2026 / 15:07, Damien Le Moal wrote:
> On 2026/07/30 14:58, Shin'ichiro Kawasaki wrote:
...
> > diff --git a/drivers/block/zloop.c b/drivers/block/zloop.c
...
> > + rq_for_each_segment(bv, rq, iter) {
> > + end = pos + bv.bv_len;
> > + if (end > zero_from) {
> > + off = 0;
> > + if (pos < zero_from)
> > + off = zero_from - pos;
>
> Maybe write this as:
>
> if (pos < zero_from)
> off = zero_from - pos;
> else
> off = 0;
>
Thanks, I reflected this change and posted v2.
prev parent reply other threads:[~2026-07-30 7:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-30 5:58 [PATCH] zloop: zero out only the unread tail of short reads Shin'ichiro Kawasaki
2026-07-30 6:07 ` Damien Le Moal
2026-07-30 7:27 ` Shin'ichiro Kawasaki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amr8tz3Bgh5lQr3H@shinmob \
--to=shinichiro.kawasaki@wdc.com \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox