Linux block layer
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Daeho Jeong <daeho43@gmail.com>
Cc: Bart Van Assche <bvanassche@acm.org>,
	Christoph Hellwig <hch@infradead.org>,
	linux-kernel@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com,
	Daeho Jeong <daehojeong@google.com>,
	linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Pavel Machek <pavel@kernel.org>, Len Brown <lenb@kernel.org>,
	linux-pm@vger.kernel.org
Subject: Re: [PATCH v2] f2fs: quiesce background threads during system suspend using PM notifier
Date: Thu, 13 Aug 2026 23:30:30 -0700	[thread overview]
Message-ID: <an62BorNrc-IX228@infradead.org> (raw)
In-Reply-To: <CACOAw_zqOS0vHdQV6WoUJyxnDf=kdDAz27pNGDLdQLUdUYOzBQ@mail.gmail.com>

On Mon, Aug 10, 2026 at 09:53:14AM -0700, Daeho Jeong wrote:
> On Mon, Aug 10, 2026 at 9:34 AM Bart Van Assche <bvanassche@acm.org> wrote:
> > This information was shared earlier with Daeho
> > (https://b.corp.google.com/issues/515470309#comment45): [ ... ]

This does not seem to be information available to the public.

> f2fs threads are already freezable: f2fs_gc and f2fs_discard are
> already registered with set_freezable() and call try_to_freeze().
> However, a race window exists: a thread checks freezing() (false),
> calls submit_bio(), and gets trapped inside __bio_queue_enter().
> Because it gets blocked before reaching try_to_freeze(), it triggers a
> PM freezer timeout.

This does sound very much like a block layer freezing issue.

> Point taken. Aside from this f2fs patch, I agree that addressing this
> at the block layer or PM subsystem level would be a much cleaner,
> system-wide solution.
> I’ll give more thought to how we can properly solve this race
> condition for the entire system, and I'll loop in the relevant
> PM/block maintainers if a viable generic approach emerges.

Thanks, it would be great to fix this properly.


      reply	other threads:[~2026-08-14  6:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260806170108.2100312-1-daeho43@gmail.com>
2026-08-10 15:54 ` [PATCH v2] f2fs: quiesce background threads during system suspend using PM notifier Christoph Hellwig
2026-08-10 16:34   ` Bart Van Assche
2026-08-10 16:53     ` Daeho Jeong
2026-08-14  6:30       ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=an62BorNrc-IX228@infradead.org \
    --to=hch@infradead.org \
    --cc=bvanassche@acm.org \
    --cc=daeho43@gmail.com \
    --cc=daehojeong@google.com \
    --cc=kernel-team@android.com \
    --cc=lenb@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pavel@kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox