From: Keith Busch <kbusch@kernel.org>
To: John Garry <john.g.garry@oracle.com>
Cc: John Garry <john.garry@linux.dev>, Christoph Hellwig <hch@lst.de>,
sagi@grimberg.me, axboe@fb.com, linux-nvme@lists.infradead.org,
linux-block@vger.kernel.org
Subject: Re: [PATCH RFC] nvme-multipath: fix diskstats for partitions
Date: Mon, 10 Aug 2026 18:55:43 -0600 [thread overview]
Message-ID: <anpzD5PaOn-_K5hn@kbusch-mbp> (raw)
In-Reply-To: <d3058b64-e162-4bfc-990d-13ff5f03143a@oracle.com>
On Thu, Jul 30, 2026 at 01:52:00PM +0100, John Garry wrote:
>
> With that, /sys/class/block/ looks a bit different (with the per-path
> partitions):
>
> #ls -l /sys/class/block/ | grep nvme0
> lrwxrwxrwx 1 root root 0 Jul 30 12:39 nvme0c0n1 ->
> ../../devices/virtual/nvme-fabrics/ctl/nvme0/nvme0c0n1
> lrwxrwxrwx 1 root root 0 Jul 30 12:39 nvme0c0n1p1
> -> ../../devices/virtual/nvme-fabrics/ctl/nvme0/nvme0c0n1/nvme0c0n1p1
> lrwxrwxrwx 1 root root 0 Jul 30 12:39 nvme0c1n1 ->
> ../../devices/virtual/nvme-fabrics/ctl/nvme1/nvme0c1n1
> lrwxrwxrwx 1 root root 0 Jul 30 12:39 nvme0c1n1p1
> -> ../../devices/virtual/nvme-fabrics/ctl/nvme1/nvme0c1n1/nvme0c1n1p1
> lrwxrwxrwx 1 root root 0 Jul 30 12:39 nvme0n1 ->
> ../../devices/virtual/nvme-subsystem/nvme-subsys0/nvme0n1
> lrwxrwxrwx 1 root root 0 Jul 30 12:39 nvme0n1p1 ->
> ../../devices/virtual/nvme-subsystem/nvme-subsys0/nvme0n1/nvme0n1p1
>
> Thoughts?
Yes, looks good to me, though I don't really know why partition scanning
was skipped in the first place. I always thought the important part was
the HIDDEN devices don't automatically enumerate in /dev/.
next prev parent reply other threads:[~2026-08-11 0:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260721114553.1657841-1-john.g.garry@oracle.com>
[not found] ` <20260724050152.GA3680@lst.de>
2026-07-24 7:09 ` [PATCH RFC] nvme-multipath: fix diskstats for partitions John Garry
2026-07-24 12:45 ` Keith Busch
2026-07-24 15:29 ` John Garry
2026-07-24 15:37 ` Keith Busch
2026-07-24 16:56 ` John Garry
2026-07-30 12:52 ` John Garry
2026-08-11 0:55 ` Keith Busch [this message]
2026-08-11 8:28 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anpzD5PaOn-_K5hn@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=john.g.garry@oracle.com \
--cc=john.garry@linux.dev \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox