Linux block layer
 help / color / mirror / Atom feed
From: Johannes Thumshirn <johannes.thumshirn@wdc.com>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org,  Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v3 01/13] block: remove disk_free_zone_resources()
Date: Tue, 11 Aug 2026 13:41:44 +0200	[thread overview]
Message-ID: <ansHsOhXTxPcUr-R@mayhem.fritz.box> (raw)
In-Reply-To: <20260811105852.1245357-2-dlemoal@kernel.org>

On Tue, Aug 11, 2026 at 07:58:40PM +0900, Damien Le Moal wrote:
> In the rare event when revalidating the zones of a zoned block device
> fails, the device capacity will be dropped to 0. In such case, the zoned
> block device will either be rescanned and restored or dropped entirely and
> its gendisk destroyed. So calling disk_free_zone_resources() from

is destroyed

> blk_revalidate_disk_zones() in case of error does not make much sense. We

an error

> can keep the zone resources in case the device is rescanned and restored
> or simply free all resources in disk_release_zone_resources() when the
> gendick is destroyed.

gendisk

> 
> Remove the call to disk_free_zone_resources() from
> blk_revalidate_disk_zones() and squash disk_free_zone_resources() inside
> disk_release_zone_resources(). With this change, the conditional creation
> of the zone write plugs work queue is not necessary anymore as the
> workqueue will keep existing together with all other resources until the
> disk is released. This simplifies disk_alloc_zone_resources().

Other than that:
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>

  reply	other threads:[~2026-08-11 11:42 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-11 10:58 [PATCH v3 00/13] Improve handling of offline and read-only zones Damien Le Moal
2026-08-11 10:58 ` [PATCH v3 01/13] block: remove disk_free_zone_resources() Damien Le Moal
2026-08-11 11:41   ` Johannes Thumshirn [this message]
2026-08-11 10:58 ` [PATCH v3 02/13] block: refactor disk_revalidate_zone_resources() Damien Le Moal
2026-08-11 11:46   ` Johannes Thumshirn
2026-08-11 10:58 ` [PATCH v3 03/13] block: refactor disk_update_zone_resources() Damien Le Moal
2026-08-11 11:28   ` Hannes Reinecke
2026-08-11 11:48   ` Johannes Thumshirn
2026-08-11 10:58 ` [PATCH v3 04/13] block: remember a zone type regardless of its condition Damien Le Moal
2026-08-11 11:29   ` Hannes Reinecke
2026-08-11 10:58 ` [PATCH v3 05/13] block: refactor bdev_zone_is_seq() Damien Le Moal
2026-08-11 11:30   ` Hannes Reinecke
2026-08-11 10:58 ` [PATCH v3 06/13] block: introduce disk_for_all_zone_wplugs() Damien Le Moal
2026-08-11 11:31   ` Hannes Reinecke
2026-08-11 10:58 ` [PATCH v3 07/13] block: drop all zone write plugs on capacity changes Damien Le Moal
2026-08-11 11:33   ` Hannes Reinecke
2026-08-11 10:58 ` [PATCH v3 08/13] block: propagate readonly and offline conditions to zone write plugs Damien Le Moal
2026-08-11 11:35   ` Hannes Reinecke
2026-08-11 10:58 ` [PATCH v3 09/13] block: always treat offline and read-only zones as dead Damien Le Moal
2026-08-11 11:36   ` Hannes Reinecke
2026-08-11 10:58 ` [PATCH v3 10/13] block: fail zone management operations to read-only and offline zones Damien Le Moal
2026-08-11 11:41   ` Hannes Reinecke
2026-08-11 12:13     ` Damien Le Moal
2026-08-11 12:16       ` Hannes Reinecke
2026-08-11 10:58 ` [PATCH v3 11/13] block: allow read-only and offline conventional zones Damien Le Moal
2026-08-11 11:43   ` Hannes Reinecke
2026-08-11 10:58 ` [PATCH v3 12/13] block: simplify disk_zone_set_cond() Damien Le Moal
2026-08-11 11:45   ` Hannes Reinecke
2026-08-11 10:58 ` [PATCH v3 13/13] block: flag zoned disks with GENHD_FL_NO_PART Damien Le Moal
2026-08-11 11:45   ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ansHsOhXTxPcUr-R@mayhem.fritz.box \
    --to=johannes.thumshirn@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=dlemoal@kernel.org \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox