From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Hao Jia <jiahao.kernel@gmail.com>,
minchan@kernel.org, senozhatsky@chromium.org, axboe@kernel.dk,
bgeffon@google.com, linux-kernel@vger.kernel.org,
linux-block@vger.kernel.org, Hao Jia <jiahao1@lixiang.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v2] zram: fix idle age_sec underflow in idle_store()
Date: Mon, 31 Aug 2026 13:15:06 +0900 [thread overview]
Message-ID: <apT-ocFYDmU6iC-j@google.com> (raw)
In-Reply-To: <20260828102446.3eb7f3dc779753b831e33fe6@linux-foundation.org>
On (26/08/28 10:24), Andrew Morton wrote:
> On Fri, 28 Aug 2026 16:31:49 +0800 Hao Jia <jiahao.kernel@gmail.com> wrote:
[..]
>
> Thanks. Sashiko asked a couple of questions about this change:
> https://sashiko.dev/#/patchset/20260828083149.45760-1-jiahao.kernel@gmail.com
> Does this early return prevent marking valid boot-time pages as idle?
> When a page is accessed during the first second of system boot, its ac_time
> would be 0.
There is no possibility for zram to hold pages during first second of
system boot, regardless of whether zram was configured as a swap device
or as a block device (mount-ed with real filesystem).
> Can the early return above bypass this zram device initialization check?
We already do that, e.g. when kstrtouint(buf, 0, &age_sec) fails. Apart
from that, that's not how one checks if device was initialized. We may
want to consolidate those checks, just for symmetry.
next prev parent reply other threads:[~2026-08-31 4:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-28 8:31 [PATCH v2] zram: fix idle age_sec underflow in idle_store() Hao Jia
2026-08-28 9:20 ` Sergey Senozhatsky
2026-08-28 17:24 ` Andrew Morton
2026-08-31 4:15 ` Sergey Senozhatsky [this message]
2026-08-31 8:37 ` Hao Jia
2026-08-31 9:38 ` Sergey Senozhatsky
2026-09-01 2:02 ` Hao Jia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apT-ocFYDmU6iC-j@google.com \
--to=senozhatsky@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=bgeffon@google.com \
--cc=jiahao.kernel@gmail.com \
--cc=jiahao1@lixiang.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox