From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED134367F58 for ; Thu, 3 Sep 2026 22:33:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788474798; cv=none; b=Rkh5ZHA+dA5kknxcD5QFkqnr546otk2HQYki2eHonzB7Zr3TQgQekZqWi7QWjUAsR2KH474EJS3rnMIBkAmb/609p7TTKjfci+kInY5vQVDLfSep1mFNVaBc+ge5eQN5QHq1ZqiaqcjVLRwQQI9zXjNl8GPzj8B8Bsw/TyOey2Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788474798; c=relaxed/simple; bh=4c3nfHzx6sq9eUFKnQag6UKfPOIkWmaO1ykpU7H4aTg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EkeXXh9iIjPfI3HUEl+GUr9a327R3FqxtHZc2liSj212zKZeOS52m78lam3SyBiz9XQQH5wHIEoxBbxeXSSj8Xlo/PKHy16TB6nc/nKjC5/YSGom8FEC4q2FTvDss3//h8FLUwtLSLBV1FI0CiXBFxCy4X6qqrwamogrAtMm5Ak= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FsHvcRhC; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FsHvcRhC" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2d6f9e2f681so4102985ad.3 for ; Thu, 03 Sep 2026 15:33:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788474796; x=1789079596; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=fsb6fC2BuVNqBfvyOr4NyKSsD45FGtfpTAVkgi/kym4=; b=FsHvcRhCU6TMl+UeBx+bnI8iEyrnBLJwSmw9MOiZMDL29XawM5rsCzPt5uvYnfeCRd VxMzbh+f/Q2YjF3tjclhwcCrez5bxpwNi+ODuX9ExQ9kfWQAjhj0CKHLgW76roI2rDKl +Bnot7RxzAuGXtuPcLje3DjlYwFhqyU21vWhmqRI3S/U/IXncIUAKQ0oO0cUeBL+qiYq WEOHWLinVimGVZhqVOZb8E/SC1kbn7fXkpq3USuc+lG57dj32GGkVg24WpiAfAeBI069 PnGalnKHaQyjpmO3Y/tlrVGVWV3mWWZI36WWV2wZnjlunR2MeRT0LiWqu1ky/vfizaYL ek7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788474796; x=1789079596; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=fsb6fC2BuVNqBfvyOr4NyKSsD45FGtfpTAVkgi/kym4=; b=CZlhkeB584Wwb//ReG36TSN+OVL1gY/CEwhAfSpGMqf4rrT1jywbQ0iI/eZ2PVPQ8U Rb46KBUUpmXbsZudTqbWNYFgQLYchpfWPrkYuSGD2JG2BBFvlOlVNmkFO6qbliErJRHx bVgy1kA/RV7KEi8bu+5s19WK2//TRGRF+1YZo8rPtzhguMoQc+yx94Sv8o3dDb2/niiw bYhdZazQ1HNwBFOKcfUyl+CNWbI9JASy0nFVqsVrN9jRn+GXWtydc5jG7Vc/ir6aGKZW odH/Vui8o4eM4fz4Y1p78aGFiV0Sjbl6jg/67H72bBbEKcESYD8UpId+ilmyuWe5OU3H SW0A== X-Forwarded-Encrypted: i=1; AKwUvBwbCi4YFpT3B1tQqZJ1YkYujg4VvkUG2kogWo8VbqPkivTj+PEyKPKq4brmgmShUDJmBNXwgU2/wEF74g==@vger.kernel.org X-Gm-Message-State: AFuF++lfQo8lPydq8hD8Y4LIgc0q2BfBpubQYzueo/8/UrnCmzyAXCMq wAlJNlNcVPIUg2eclHXFAgdmJHbI4KxAAOVD4fHoZQv6IY4G1ct6GQLn X-Gm-Gg: AYBFou2MtkRIEObsX8E8lmqLT/ej6nk+M5/aPgBOumAeDvNn0DQ4DGdvuNHAU03Tdb6 L3pEszrxm43Ae62F3n2dfKMhmn8nAqml8LHxX5SaX4aS3Yfc7iLeuFzb472x/ZgwHrkoWxztfgN 179VOD2K+uGSUAQQRYnvXhHFsTdwZvkJcfQ2aRyDMUNg6dty9eUhTe5KT+6j//IqmSQG2jicYAL 81pAgDEcrAEM+W8n32PILI+qDpOCGzIJKW68+zyeaEy8ddKMXvq+2S9fqUJgot5zGWM1c+Rg0Gx gVFH4tdWmqcWia5akwCyoHkJjIbq+4yjxRKKjLGT3qDa/TPVELlnAmYLNllCSfRBU0y59gBiBbt Ece71BH3t2DmRNsuZoQn9L+rRYmTsWRnjmxbvgZzaxOAKC6GRg5QIydXEM8Hz74GfFIebb1aBdw fS+O4qZ5ZQeOX3h44WFFPvnAaQHSoW1yAaNAqsdQ1929LxZSoNNeZI49Ai1gcCEw1YRvxKUFSyj QM7HvSV X-Received: by 2002:a17:90b:268f:b0:398:c3a3:dbd0 with SMTP id 98e67ed59e1d1-39b2612eb96mr2849147a91.8.1788474796180; Thu, 03 Sep 2026 15:33:16 -0700 (PDT) Received: from devvm16600.scu0.facebook.com ([2a03:2880:9ff:73::]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3339a534d25sm1797152eec.5.2026.09.03.15.33.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Sep 2026 15:33:15 -0700 (PDT) Date: Thu, 3 Sep 2026 15:33:12 -0700 From: Ziyang Men To: Shakeel Butt Cc: kernel-team@meta.com, Jens Axboe , Tejun Heo , Josef Bacik , Johannes Weiner , Michal =?iso-8859-1?Q?Koutn=FD?= , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Shuah Khan , Ingo Molnar , Peter Zijlstra , Vincent Guittot , Ben Segall , Dietmar Eggemann , Martin KaFai Lau , Song Liu , Yonghong Song , Jiri Olsa , Emil Tsalapatis , Roman Gushchin , JP Kobryn , Mykola Lysenko , linux-block@vger.kernel.org, bpf@vger.kernel.org, cgroups@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/4] cgroup: expose cpu.stat and io.stat to BPF Message-ID: References: <20260820211758.3393984-1-ziyang.meme@gmail.com> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: On Wed, Sep 02, 2026 at 04:10:01PM -0700, Shakeel Butt wrote: >On Mon, Aug 31, 2026 at 03:16:10PM -0700, Ziyang Men wrote: >> Hi Reviewers, >> >> Just want to follow-up on this patch series. Please let me know the possible >> issues and I will fix them. >> > >AI bots have raised real concerns. Please address those and then resubmit. > Hi Shakeel, I have reviewed the AI bots suggestions, and it seems the main issue is to decide whether we want some kfuncs to be NMI safe, e.g., - The `bpf_cgroup_base_stat()`, which calls the `cputime_adjust()` and in turn acquires `raw_spin_lock_irqsave()`. - The `bpf_cgroup_css()` and `bpf_css_release()` to get/put the css. The simply solution is to mark them SLEEPABLE. Hi Eduard, what's your idea about this? Do we want to mark them SLEEPABLE or there are better ways stand in the mid? Thanks, Ziyang