From: Herbert Xu <herbert@gondor.apana.org.au>
To: Leonid Ravich <lravich@amazon.com>
Cc: linux-crypto@vger.kernel.org, dm-devel@lists.linux.dev,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
davem@davemloft.net, ebiggers@kernel.org, snitzer@kernel.org,
mpatocka@redhat.com, axboe@kernel.dk
Subject: Re: [PATCH v5 4/5] dm crypt: batch a bio segment's sectors via dun()
Date: Sat, 19 Sep 2026 14:08:32 +1000 [thread overview]
Message-ID: <aq4KwKXFBJctXlAY@gondor.apana.org.au> (raw)
In-Reply-To: <20260630083431.2772-5-lravich@amazon.com>
On Tue, Jun 30, 2026 at 08:34:30AM +0000, Leonid Ravich wrote:
>
> @@ -1410,7 +1452,9 @@ static int crypt_convert_block_skcipher(struct crypt_config *cc,
> memcpy(iv, org_iv, cc->iv_size);
> }
>
> - skcipher_request_set_crypt(req, sg_in, sg_out, cc->sector_size, iv);
> + skcipher_request_set_crypt(req, sg_in, sg_out, len, iv);
> + /* A dun() tfm reads this; a plain skcipher ignores it (len is one sector). */
> + skcipher_request_set_data_unit_size(req, sector_size);
Is this going to use the generated IV for reading through dm-crypt?
Shouldn't it be using the IV stored on disk instead of generating it
again for reading?
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2026-09-19 4:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-30 8:34 [PATCH v5 0/5] crypto: skcipher - multi-data-unit dispatch as a template Leonid Ravich
2026-06-30 8:34 ` [PATCH v5 1/5] crypto: skcipher - add per-request data_unit_size Leonid Ravich
2026-07-13 2:19 ` Herbert Xu
2026-06-30 8:34 ` [PATCH v5 2/5] crypto: dun - data-unit-number dispatch template Leonid Ravich
2026-07-13 2:25 ` Herbert Xu
2026-07-15 12:01 ` Leonid Ravich
2026-09-19 4:30 ` Herbert Xu
2026-06-30 8:34 ` [PATCH v5 3/5] crypto: testmgr - test dun() dispatch Leonid Ravich
2026-06-30 8:34 ` [PATCH v5 4/5] dm crypt: batch a bio segment's sectors via dun() Leonid Ravich
2026-07-16 13:34 ` kernel test robot
2026-09-19 4:08 ` Herbert Xu [this message]
2026-07-01 6:53 ` [PATCH v5 5/5] blk-crypto: fallback - batch a segment's data units " Leonid Ravich
2026-07-01 7:19 ` [PATCH v5 0/5] crypto: skcipher - multi-data-unit dispatch as a template Eric Biggers
2026-07-02 8:45 ` Leonid Ravich
2026-07-02 16:45 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aq4KwKXFBJctXlAY@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=axboe@kernel.dk \
--cc=davem@davemloft.net \
--cc=dm-devel@lists.linux.dev \
--cc=ebiggers@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lravich@amazon.com \
--cc=mpatocka@redhat.com \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox