Re: [PATCH blktests] src/Makefile: fix HAVE_C_DEF probe under a non-bash /bin/sh

[Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>]

On Sep 08, 2026 / 14:48, Mohamed Khalfella wrote:
> HAVE_C_DEF feeds its test program to the compiler with "echo -e". The
> $(shell ...) function runs under /bin/sh, which is dash on Debian and
> Ubuntu, and dash's echo has no -e option. It prints the flag literally,
> so the first line of the probe becomes
> 
>     -e #include <linux/ublk_cmd.h>
> 
> which is no longer a preprocessor directive. The header is never
> included, the tested macro is never defined, and the probe reports 0
> regardless of what the installed headers contain.
> 
> The only user is HAVE_NEW_UBLK_INTF, so miniublk is skipped with
> 
>     Skip miniublk build due to missing new ublk interface(v6.4+)
> 
> Use printf instead, which expands \n in any POSIX shell, and pass the
> substituted names as arguments so they are not reinterpreted.
> 
> Signed-off-by: Mohamed Khalfella <mkhalfella@purestorage.com>

I applied the patch. Thanks!