From: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To: Tal Zussman <tz2294@columbia.edu>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH blktests 0/3] blktests: tests for the direct I/O fallback, splice, and bio trimming fixes
Date: Fri, 18 Sep 2026 11:49:31 +0900 [thread overview]
Message-ID: <aqyll5sZ6qrYzo3W@shinmob> (raw)
In-Reply-To: <20260909-blkdev-fixes-tests-v1-0-1f8af8665d16@columbia.edu>
On Sep 09, 2026 / 15:39, Tal Zussman wrote:
> Three regression tests for block device fixes under review [1],
> following block/048 for the first patch of that series.
>
> block/049 races partial O_DIRECT writes, which finish through the
> direct I/O write fallback, against BLKBSZSET. block/050 does the same
> with splice(). Both need CONFIG_DEBUG_VM to report the folio order
> mismatch, and skip on kernels without a 64K block size or with 64K
> pages.
>
> block/051 issues trimmed O_DIRECT writes from a hugetlb mapping to a
> device with a 64K logical block size and checks that no huge pages
> leak, covering both the dropped and the shrunk bvec.
>
> [1] https://lore.kernel.org/linux-block/20260828-blkdev-fixes-v2-0-32f3f40cebed@columbia.edu/
Thanks for the series. The patches all look good to me.
I ran the new tests cases with and without the kernel side v3 patches [2] and
confirmed that the test cases trigger the expected failures and the kernel fix
patches avoid the failrues. Good.
[2] https://lore.kernel.org/linux-block/20260909-blkdev-fixes-v3-0-1a5222c6e8ad@columbia.edu/
I will wait for the kernel side patches get settled to Linus master branch
before I apply the blktests patches.
next prev parent reply other threads:[~2026-09-18 2:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 19:39 [PATCH blktests 0/3] blktests: tests for the direct I/O fallback, splice, and bio trimming fixes Tal Zussman
2026-09-09 19:39 ` [PATCH blktests 1/3] block/049: add a direct I/O write fallback race test for block devices Tal Zussman
2026-09-09 19:39 ` [PATCH blktests 2/3] block/050: add a splice read " Tal Zussman
2026-09-09 19:39 ` [PATCH blktests 3/3] block/051: add a pinned page leak test for trimmed direct writes Tal Zussman
2026-09-18 2:49 ` Shin'ichiro Kawasaki [this message]
2026-09-19 5:16 ` [PATCH blktests 0/3] blktests: tests for the direct I/O fallback, splice, and bio trimming fixes Tal Zussman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqyll5sZ6qrYzo3W@shinmob \
--to=shinichiro.kawasaki@wdc.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=tz2294@columbia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox